Repository navigation
make seech service extend base service and use the auth helper - #1156
Merged
Harleen Thind (hathind-ms) merged 7 commits intoMay 22, 2023
Merged
Harleen Thind (hathind-ms) merged 7 commits into
Harleen Thind (hathind-ms) merged 7 commits into
Conversation
Aman Sachan (amsacha)
added
the
PR: ready for review
Gil LaHaye (glahaye)
previously approved these changes
May 22, 2023
Aman Sachan (amsacha)
requested review from
Gil LaHaye (glahaye) and
Teresa Hoang (teresaqhoang)
May 22, 2023 20:22
Aman Sachan (amsacha)
force-pushed
the
SupportApiKeyAuthOnSpeechService
branch
from
May 22, 2023 20:24
f84da22 to
170f75f
Compare
Teresa Hoang (teresaqhoang)
approved these changes
May 22, 2023
Harleen Thind (hathind-ms)
approved these changes
May 22, 2023
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…soft#1156) ### Motivation and Context Make SpeechService extend the BaseService class and use the AuthHelper class. This also fixes a bug where the speech service did not support the ApiKey auth. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Adrian Bonar <[email protected]> Co-authored-by: Harleen Thind <[email protected]>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…soft#1156) ### Motivation and Context Make SpeechService extend the BaseService class and use the AuthHelper class. This also fixes a bug where the speech service did not support the ApiKey auth. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Adrian Bonar <[email protected]> Co-authored-by: Harleen Thind <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Make SpeechService extend the BaseService class and use the AuthHelper class. This also fixes a bug where the speech service did not support the ApiKey auth.
Contribution Checklist
dotnet format