Repository navigation
CopilotChat: Low-level memory optimizations when uploading bot - #1149
Merged
Adrian Bonar (adrianwyatt) merged 2 commits intoMay 22, 2023
Merged
Conversation
Adrian Bonar (adrianwyatt)
requested review from
Tao Chen (TaoChenOSU) and
Vivien Hung (Vivihung)
May 22, 2023 15:47
Harleen Thind (hathind-ms)
previously approved these changes
May 22, 2023
Tao Chen (TaoChenOSU)
previously approved these changes
May 22, 2023
Gil LaHaye (glahaye)
previously approved these changes
May 22, 2023
Adrian Bonar (adrianwyatt)
changed the title
Adrian Bonar (adrianwyatt)
dismissed stale reviews from Gil LaHaye (glahaye), Tao Chen (TaoChenOSU), and Harleen Thind (hathind-ms)
via
May 22, 2023 17:25
6240f5c
Adrian Bonar (adrianwyatt)
requested review from
Tao Chen (TaoChenOSU),
Gil LaHaye (glahaye) and
Harleen Thind (hathind-ms)
May 22, 2023 17:26
Adrian Bonar (adrianwyatt)
enabled auto-merge (squash)
May 22, 2023 17:26
Adrian Bonar (adrianwyatt)
added
the
.NET
Tao Chen (TaoChenOSU)
approved these changes
May 22, 2023
Adrian Bonar (adrianwyatt)
added
the
PR: ready to merge
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…soft#1149) ### Motivation and Context High level semantic memory implementations, such as Azure Cognitive Search, do not allow for providing embeddings when storing memories. We wrap the memory store in an optional memory store to allow controllers to pass dependency injection validation and potentially optimize for a lower-level memory implementation (e.g. Qdrant). Lower level memory implementations (i.e., IMemoryStore) allow for reusing embeddings, whereas high level memory implementation (i.e., ISemanticTextMemory) assume embeddings get recalculated on every write. ### Description - Implemented OptionalIMemoryStore to allow for BotController to pass DI validation and decide on using IMemoryStore or ISemanticTextMemory when uploading a bot.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…soft#1149) ### Motivation and Context High level semantic memory implementations, such as Azure Cognitive Search, do not allow for providing embeddings when storing memories. We wrap the memory store in an optional memory store to allow controllers to pass dependency injection validation and potentially optimize for a lower-level memory implementation (e.g. Qdrant). Lower level memory implementations (i.e., IMemoryStore) allow for reusing embeddings, whereas high level memory implementation (i.e., ISemanticTextMemory) assume embeddings get recalculated on every write. ### Description - Implemented OptionalIMemoryStore to allow for BotController to pass DI validation and decide on using IMemoryStore or ISemanticTextMemory when uploading a bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
High level semantic memory implementations, such as Azure Cognitive Search, do not allow for providing embeddings when storing memories. We wrap the memory store in an optional memory store to allow controllers to pass dependency injection validation and potentially optimize for a lower-level memory implementation (e.g. Qdrant). Lower level memory implementations (i.e., IMemoryStore) allow for reusing embeddings, whereas high level memory implementation (i.e., ISemanticTextMemory) assume embeddings get recalculated on every write.
Description