Repository navigation
Enable more C# code style checks + fixes - #1142
Merged
Merged
Conversation
github-actions
Bot
added
.NET
Devis Lucato (dluc)
requested review from
Shawn Callegari (shawncal) and
Stephen Toub (stephentoub)
May 22, 2023 02:52
Devis Lucato (dluc)
added
the
PR: ready for review
Devis Lucato (dluc)
changed the title
Devis Lucato (dluc)
force-pushed
the
dluc158cs
branch
2 times, most recently
from
May 22, 2023 07:43
70504b6 to
83e4d51
Compare
Shawn Callegari (shawncal)
approved these changes
May 22, 2023
Shawn Callegari (shawncal)
force-pushed
the
dluc158cs
branch
from
May 22, 2023 17:56
83e4d51 to
cec11a8
Compare
Shawn Callegari (shawncal)
enabled auto-merge (squash)
May 22, 2023 17:56
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
1. Fix missing `this.` and `Async` suffix 2. Fix some indentation, spacing, etc. 3. Enable these rules and format accordingly: IDE0001: Simplify name IDE0005: Remove unnecessary using directives IDE0009: Add this or Me qualification IDE0011: Add braces IDE0018: Inline variable declaration IDE0032: Use auto-implemented property IDE0034: Simplify 'default' expression IDE0035: Remove unreachable code IDE0040: Add accessibility modifiers IDE0049: Use language keywords instead of framework type names for type references IDE0050: Convert anonymous type to tuple IDE0051: Remove unused private member IDE0055: Formatting rule IDE0060: Remove unused parameter IDE0070: Use 'System.HashCode.Combine' IDE0071: Simplify interpolation IDE0073: Require file header IDE0082: Convert typeof to nameof IDE0090: Simplify new expression IDE0161: Use file-scoped namespace
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
1. Fix missing `this.` and `Async` suffix 2. Fix some indentation, spacing, etc. 3. Enable these rules and format accordingly: IDE0001: Simplify name IDE0005: Remove unnecessary using directives IDE0009: Add this or Me qualification IDE0011: Add braces IDE0018: Inline variable declaration IDE0032: Use auto-implemented property IDE0034: Simplify 'default' expression IDE0035: Remove unreachable code IDE0040: Add accessibility modifiers IDE0049: Use language keywords instead of framework type names for type references IDE0050: Convert anonymous type to tuple IDE0051: Remove unused private member IDE0055: Formatting rule IDE0060: Remove unused parameter IDE0070: Use 'System.HashCode.Combine' IDE0071: Simplify interpolation IDE0073: Require file header IDE0082: Convert typeof to nameof IDE0090: Simplify new expression IDE0161: Use file-scoped namespace
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
1. Fix missing `this.` and `Async` suffix 2. Fix some indentation, spacing, etc. 3. Enable these rules and format accordingly: IDE0001: Simplify name IDE0005: Remove unnecessary using directives IDE0009: Add this or Me qualification IDE0011: Add braces IDE0018: Inline variable declaration IDE0032: Use auto-implemented property IDE0034: Simplify 'default' expression IDE0035: Remove unreachable code IDE0040: Add accessibility modifiers IDE0049: Use language keywords instead of framework type names for type references IDE0050: Convert anonymous type to tuple IDE0051: Remove unused private member IDE0055: Formatting rule IDE0060: Remove unused parameter IDE0070: Use 'System.HashCode.Combine' IDE0071: Simplify interpolation IDE0073: Require file header IDE0082: Convert typeof to nameof IDE0090: Simplify new expression IDE0161: Use file-scoped namespace
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
1. Fix missing `this.` and `Async` suffix 2. Fix some indentation, spacing, etc. 3. Enable these rules and format accordingly: IDE0001: Simplify name IDE0005: Remove unnecessary using directives IDE0009: Add this or Me qualification IDE0011: Add braces IDE0018: Inline variable declaration IDE0032: Use auto-implemented property IDE0034: Simplify 'default' expression IDE0035: Remove unreachable code IDE0040: Add accessibility modifiers IDE0049: Use language keywords instead of framework type names for type references IDE0050: Convert anonymous type to tuple IDE0051: Remove unused private member IDE0055: Formatting rule IDE0060: Remove unused parameter IDE0070: Use 'System.HashCode.Combine' IDE0071: Simplify interpolation IDE0073: Require file header IDE0082: Convert typeof to nameof IDE0090: Simplify new expression IDE0161: Use file-scoped namespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this.andAsyncsuffixIDE0001: Simplify name
IDE0005: Remove unnecessary using directives
IDE0009: Add this or Me qualification
IDE0011: Add braces
IDE0018: Inline variable declaration
IDE0032: Use auto-implemented property
IDE0034: Simplify 'default' expression
IDE0035: Remove unreachable code
IDE0040: Add accessibility modifiers
IDE0049: Use language keywords instead of framework type names for type references
IDE0050: Convert anonymous type to tuple
IDE0051: Remove unused private member
IDE0055: Formatting rule
IDE0060: Remove unused parameter
IDE0070: Use 'System.HashCode.Combine'
IDE0071: Simplify interpolation
IDE0073: Require file header
IDE0082: Convert typeof to nameof
IDE0090: Simplify new expression
IDE0161: Use file-scoped namespace