Repository navigation
Improve chat controller logging - #1123
Merged
Harleen Thind (hathind-ms) merged 2 commits intoMay 20, 2023
Merged
Conversation
Gil LaHaye (glahaye)
requested review from
Adrian Bonar (adrianwyatt),
Craig Presti (craigomatic) and
Harleen Thind (hathind-ms)
May 20, 2023 00:25
Tao Chen (TaoChenOSU)
approved these changes
May 20, 2023
Harleen Thind (hathind-ms)
approved these changes
May 20, 2023
Harleen Thind (hathind-ms)
approved these changes
May 20, 2023
Harleen Thind (hathind-ms)
enabled auto-merge (squash)
May 20, 2023 00:31
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Motivation and Context Chat is emitting 404 and we want more info. ### Description Adjusted log level and added exception info. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Harleen Thind <[email protected]>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context Chat is emitting 404 and we want more info. ### Description Adjusted log level and added exception info. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Harleen Thind <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Chat is emitting 404 and we want more info.
Description
Adjusted log level and added exception info.
Contribution Checklist
dotnet format