Skip to content

CopilotChat: Replace "SK" with "SemanticKernel" and add App Service Plan allowable values. - #1109

Merged
Adrian Bonar (adrianwyatt) merged 19 commits into
microsoft:mainfrom
adrianwyatt:bug-19228
May 19, 2023
Merged

Adrian Bonar (adrianwyatt) merged 19 commits into
microsoft:mainfrom
adrianwyatt:bug-19228

Conversation

@adrianwyatt

@adrianwyatt Adrian Bonar (adrianwyatt) commented May 19, 2023 •

Copy link
Copy Markdown
Contributor

Motivation and Context

Remove most occurrences of "SK" from CopilotChat deployment

Description

  • Renamed most occurrences of "SK" to either "SemanticKernel" or "SemKer" throughout CopilotChat
  • Updated App Plan SKUs with a list of allowed values.

@hathind-ms Harleen Thind (hathind-ms) changed the title Bug 19228 Updates to Azure Deployment scripts May 19, 2023
@adrianwyatt Adrian Bonar (adrianwyatt) added the PR: ready for review All feedback addressed, ready for reviews label May 19, 2023
@adrianwyatt

Copy link
Copy Markdown
Contributor Author

Still doing some validation - hold merge until I've finished.

@adrianwyatt Adrian Bonar (adrianwyatt) changed the title Updates to Azure Deployment scripts CopilotChat: Replace "SK" with "SemanticKernel" and add App Service Plan allowable values. May 19, 2023
@hathind-ms

Copy link
Copy Markdown
Contributor

@adrianwyatt

Copy link
Copy Markdown
Contributor Author

This change is missing:

Package URI from https://skaasdeploy.blob.core.windows.net/api/skaas.zip to be https://semantic-kernel-deploy.blob.core.windows.net/api/Semantic-Kernel.zip

We'll need to standup another blob service and populate it. I wanted to not block these changes on that move. I'll look at that next.

@adrianwyatt
Adrian Bonar (adrianwyatt) merged commit a3af1ca into microsoft:main May 19, 2023
@adrianwyatt
Adrian Bonar (adrianwyatt) deleted the bug-19228 branch May 22, 2023 17:36
Shawn Callegari (shawncal) pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
…lan allowable values. (microsoft#1109)

### Motivation and Context
Remove most occurrences of "SK" from CopilotChat deployment

### Description
- Renamed most occurrences of "SK" to either "SemanticKernel" or
"SemKer" throughout CopilotChat
- Updated App Plan SKUs with a list of allowed values.

---------

Co-authored-by: Harleen Thind <[email protected]>
Co-authored-by: Gil LaHaye <[email protected]>
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
…lan allowable values. (microsoft#1109)

### Motivation and Context
Remove most occurrences of "SK" from CopilotChat deployment

### Description
- Renamed most occurrences of "SK" to either "SemanticKernel" or
"SemKer" throughout CopilotChat
- Updated App Plan SKUs with a list of allowed values.

---------

Co-authored-by: Harleen Thind <[email protected]>
Co-authored-by: Gil LaHaye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready for review All feedback addressed, ready for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants