Skip to content

.Net: Target net462 in all MEVD connectors - #11077

Merged
Shay Rojansky (roji) merged 1 commit into
microsoft:feature-vector-data-preb2from
roji:net462
Mar 20, 2025
Merged

Shay Rojansky (roji) merged 1 commit into
microsoft:feature-vector-data-preb2from
roji:net462

Conversation

@roji

Copy link
Copy Markdown
Member

Aligning with MEAI; this helps netfx users under net472 (link).

@roji
Shay Rojansky (roji) requested a review from a team as a code owner March 19, 2025 21:58
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Mar 19, 2025
@github-actions github-actions Bot changed the title Target net462 in all MEVD connectors .Net: Target net462 in all MEVD connectors Mar 19, 2025
@roji Shay Rojansky (roji) self-assigned this Mar 19, 2025
@roji Shay Rojansky (roji) added msft.ext.vectordata Related to Microsoft.Extensions.VectorData and removed kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 19, 2025
<AssemblyName>Microsoft.SemanticKernel.Connectors.Postgres</AssemblyName>
<RootNamespace>$(AssemblyName)</RootNamespace>
<TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net8.0;netstandard2.0;net462</TargetFrameworks>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pgvector-dotnet currently only supports net6.0. Add net462 directly, does it work?
<TargetFrameworks>net6.0</TargetFrameworks>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin currently targets PgVector 0.2.0, which does target netstandard2.0. But we should indeed be targeting 0.3.0, which doesn't - I'll take a look.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI submitted pgvector/pgvector-dotnet#48 to pgvector.

@roji
Shay Rojansky (roji) merged commit 9732543 into microsoft:feature-vector-data-preb2 Mar 20, 2025
@roji
Shay Rojansky (roji) deleted the net462 branch March 20, 2025 09:27

This branch was previously deployed

1 inactive deployment
integration — de1c1ab0 Deployed Mar 19, 2025 by roji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

memory msft.ext.vectordata Related to Microsoft.Extensions.VectorData .NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants