Repository navigation
.Net: Obsolete the IMemoryStore where an IVectorStore implementation exists - #11040
Merged
Shay Rojansky (roji) merged 2 commits intoMar 19, 2025
Merged
Shay Rojansky (roji) merged 2 commits into
Shay Rojansky (roji) merged 2 commits into
Conversation
Mark Wallace (markwallace-microsoft)
added
.NET
github-actions
Bot
changed the title
Shay Rojansky (roji)
had a problem deploying
to
integration
March 18, 2025 13:27 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Shay Rojansky (roji)
force-pushed
the
ObsoleteMemoryStory
branch
from
March 18, 2025 13:49
c1d4709 to
1c4944b
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
March 18, 2025 13:50 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Shay Rojansky (roji)
force-pushed
the
ObsoleteMemoryStory
branch
from
March 18, 2025 14:52
1c4944b to
971e9db
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
March 18, 2025 14:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Dmytro Struk (dmytrostruk)
approved these changes
Mar 18, 2025
Shay Rojansky (roji)
force-pushed
the
ObsoleteMemoryStory
branch
from
March 19, 2025 12:35
8e8076f to
fbda71a
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
March 19, 2025 12:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Shay Rojansky (roji)
force-pushed
the
ObsoleteMemoryStory
branch
from
March 19, 2025 14:50
fbda71a to
c8fbb55
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
March 19, 2025 14:51 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This obsoletes the IMemoryStore implementations for all connectors where a new IVectorStore implementation exists. I've left the other connectors - and the IMemoryStore abstraction itself - un-obsolete for now, since users of those connectors don't yet have an upgrade path. These are still marked as experimental, so we'll be able to obsolete and remove them later.
Closes #10808