Repository navigation
Copilot Chat - Analyzers, detach from dotnet props - #1091
Merged
Adrian Bonar (adrianwyatt) merged 6 commits intoMay 19, 2023
Merged
Conversation
Shawn Callegari (shawncal)
requested review from
Tao Chen (TaoChenOSU),
Adrian Bonar (adrianwyatt) and
Harleen Thind (hathind-ms)
May 19, 2023 02:39
Shawn Callegari (shawncal)
force-pushed
the
copilotchat-analyzers
branch
3 times, most recently
from
May 19, 2023 04:00
87d292c to
ab8f1dc
Compare
Shawn Callegari (shawncal)
force-pushed
the
copilotchat-analyzers
branch
from
May 19, 2023 04:07
ab8f1dc to
1eacc55
Compare
Lee Miller (lemillermicrosoft)
approved these changes
May 19, 2023
Lee Miller (lemillermicrosoft)
added
PR: ready for review
Contributor
Author
|
Let's wait for Adrian Bonar (@adrianwyatt) Tao Chen (@TaoChenOSU) or Harleen Thind (@hathind-ms) to approve. This one's for you folks, so if you're happy with it, go ahead and merge. |
Adrian Bonar (adrianwyatt)
approved these changes
May 19, 2023
Adrian Bonar (adrianwyatt)
enabled auto-merge (squash)
May 19, 2023 23:54
Shawn Callegari (shawncal)
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description Removing Copilot Chat's import of the /dotnet/ folder's common props: ``` <Import Project="$(RepoRoot)/dotnet/Directory.Build.targets" /> <Import Project="$(RepoRoot)/dotnet/Directory.Build.props" /> ``` This allows the project folder to be copied out of the repo and run independently. Adding the useful props to Copilot Chat's csproj file. Adding the analyzers in use by dotnet, and fixing style violations they pick up. (Note: these analyzers are optional and can be added/removed in Copilot Chat without affecting the rest of the repo).
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Description Removing Copilot Chat's import of the /dotnet/ folder's common props: ``` <Import Project="$(RepoRoot)/dotnet/Directory.Build.targets" /> <Import Project="$(RepoRoot)/dotnet/Directory.Build.props" /> ``` This allows the project folder to be copied out of the repo and run independently. Adding the useful props to Copilot Chat's csproj file. Adding the analyzers in use by dotnet, and fixing style violations they pick up. (Note: these analyzers are optional and can be added/removed in Copilot Chat without affecting the rest of the repo).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing Copilot Chat's import of the /dotnet/ folder's common props:
This allows the project folder to be copied out of the repo and run independently.
Adding the useful props to Copilot Chat's csproj file. Adding the analyzers in use by dotnet, and fixing style violations they pick up. (Note: these analyzers are optional and can be added/removed in Copilot Chat without affecting the rest of the repo).
Contribution Checklist
dotnet format