Repository navigation
Upgrade .NET notebooks to latest nuget - #1089
Merged
Lee Miller (lemillermicrosoft) merged 2 commits intoMay 19, 2023
Merged
Conversation
Devis Lucato (dluc)
added
the
PR: ready for review
github-actions
Bot
added
.NET
Devis Lucato (dluc)
force-pushed
the
dluc158notebooks
branch
from
May 19, 2023 01:12
bfe2a14 to
5ef4a25
Compare
Alex Chao (alexchaomander)
self-requested a review
May 19, 2023 14:39
Alex Chao (alexchaomander)
approved these changes
May 19, 2023
Alex Chao (alexchaomander)
left a comment
Alex Chao (alexchaomander)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. What's the guidance in C# moving forward for RunAsync vs InvokeAsync? Should people ever use RunAsync?
Lee Miller (lemillermicrosoft)
enabled auto-merge (squash)
May 19, 2023 18:18
This was referenced May 19, 2023
Closed
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
* Upgrade to latest nuget, remove service ID * Simplify initial book to avoid redundant settings and information about the AI credentials * Change from kernel.RunAsync to function.InvokeAsync * align chat code across notebooks Co-authored-by: Lee Miller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.