Skip to content

Fix MIME type console error and enable WebApp production build - #1085

Merged
Harleen Thind (hathind-ms) merged 5 commits into
microsoft:mainfrom
teresaqhoang:fixing-webapp-bugs
May 19, 2023
Merged

Harleen Thind (hathind-ms) merged 5 commits into
microsoft:mainfrom
teresaqhoang:fixing-webapp-bugs

Conversation

@teresaqhoang

Copy link
Copy Markdown
Contributor

Motivation and Context

This PR fixes the MIME Type error we were seeing in the console and adds details for running a production build.

Currently, we have the WebApp wrapped in React.StrictMode, which enables additional development behaviors, including rendering the App.tsx component twice to find bugs caused by impure rendering. Since StrictMode is development only, serving a production build of the WebApp avoids double rendering the app, so wanted to provide it as an option for developers.

Description

MIME type error we were observing:
image

Contribution Checklist

@teresaqhoang Teresa Hoang (teresaqhoang) changed the title Fixing webapp bugs Fix MIME type console error and enable WebApp production build May 18, 2023
@teresaqhoang Teresa Hoang (teresaqhoang) added the PR: ready for review All feedback addressed, ready for reviews label May 18, 2023

@Vivihung Vivien Hung (Vivihung) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@hathind-ms
Harleen Thind (hathind-ms) enabled auto-merge (squash) May 19, 2023 00:07
@hathind-ms
Harleen Thind (hathind-ms) merged commit 3488656 into microsoft:main May 19, 2023
@teresaqhoang
Teresa Hoang (teresaqhoang) deleted the fixing-webapp-bugs branch May 19, 2023 00:08
Shawn Callegari (shawncal) pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
…soft#1085)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
This PR fixes the MIME Type error we were seeing in the console and adds
details for running a production build.

Currently, we have the WebApp wrapped in React.StrictMode, which enables
additional development behaviors, including rendering the App.tsx
component twice to find bugs caused by impure rendering. Since
StrictMode is development only, serving a production build of the WebApp
avoids double rendering the app, so wanted to provide it as an option
for developers.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
MIME type error we were observing: 

![image](https://github.com/microsoft/semantic-kernel/assets/125500434/f529565a-163c-401d-b53e-6be051b27c01)

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
…soft#1085)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
This PR fixes the MIME Type error we were seeing in the console and adds
details for running a production build.

Currently, we have the WebApp wrapped in React.StrictMode, which enables
additional development behaviors, including rendering the App.tsx
component twice to find bugs caused by impure rendering. Since
StrictMode is development only, serving a production build of the WebApp
avoids double rendering the app, so wanted to provide it as an option
for developers.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
MIME type error we were observing: 

![image](https://github.com/microsoft/semantic-kernel/assets/125500434/f529565a-163c-401d-b53e-6be051b27c01)

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready for review All feedback addressed, ready for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants