Repository navigation
Improve error messages displayed in copliot chat front end - #1083
Merged
Adrian Bonar (adrianwyatt) merged 8 commits intoMay 19, 2023
Merged
Adrian Bonar (adrianwyatt) merged 8 commits into
Adrian Bonar (adrianwyatt) merged 8 commits into
Conversation
github-actions
Bot
added
.NET
Aman Sachan (amsacha)
added
PR: ready for review
Contributor
|
Please add a screenshot |
Aman Sachan (amsacha)
force-pushed
the
FixAcquireExternalInformationErrorResponse
branch
3 times, most recently
from
May 18, 2023 23:11
6d9057d to
550a075
Compare
Lee Miller (lemillermicrosoft)
previously approved these changes
May 18, 2023
Harleen Thind (hathind-ms)
previously approved these changes
May 18, 2023
Adrian Bonar (adrianwyatt)
requested changes
May 19, 2023
Adrian Bonar (adrianwyatt)
added
PR: feedback to address
Aman Sachan (amsacha)
dismissed stale reviews from Harleen Thind (hathind-ms) and Lee Miller (lemillermicrosoft)
via
May 19, 2023 07:08
f67ef7e
Aman Sachan (amsacha)
force-pushed
the
FixAcquireExternalInformationErrorResponse
branch
from
May 19, 2023 07:08
550a075 to
f67ef7e
Compare
Aman Sachan (amsacha)
force-pushed
the
FixAcquireExternalInformationErrorResponse
branch
from
May 19, 2023 07:36
f67ef7e to
92d989f
Compare
Aman Sachan (amsacha)
removed
the
PR: feedback to address
Aman Sachan (amsacha)
added
the
PR: ready for review
Aman Sachan (amsacha)
requested review from
Adrian Bonar (adrianwyatt),
Harleen Thind (hathind-ms) and
Lee Miller (lemillermicrosoft)
May 19, 2023 07:38
Lee Miller (lemillermicrosoft)
previously approved these changes
May 19, 2023
Lee Miller (lemillermicrosoft)
added
the
PR: ready to merge
Harleen Thind (hathind-ms)
previously approved these changes
May 19, 2023
Adrian Bonar (adrianwyatt)
requested changes
May 19, 2023
…xternalInformationErrorResponse
Aman Sachan (amsacha)
dismissed stale reviews from Harleen Thind (hathind-ms) and Lee Miller (lemillermicrosoft)
via
May 19, 2023 17:32
c7e3de1
Lee Miller (lemillermicrosoft)
approved these changes
May 19, 2023
Adrian Bonar (adrianwyatt)
approved these changes
May 19, 2023
Adrian Bonar (adrianwyatt)
enabled auto-merge (squash)
May 19, 2023 17:41
Shawn Callegari (shawncal)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…#1083) ### Motivation and Context Improve error messages displayed in copliot chat front end. <img width="1917" alt="betterErrorResponse" src="https://github.com/microsoft/semantic-kernel/assets/51973971/50c37abf-a59e-41e8-a42b-ada975802344"> **Note:** This also involves changes to the semantic kernel, therefore it will be available when new nuget packages are published. Until then you will have to change .\samples\apps\copilot-chat-app\webapi\CopilotChatWebApi.csproj manually to load project reference instead of the respective package references to see this change.
Aman Sachan (amsacha)
deleted the
FixAcquireExternalInformationErrorResponse
branch
May 23, 2023 20:50
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…#1083) ### Motivation and Context Improve error messages displayed in copliot chat front end. <img width="1917" alt="betterErrorResponse" src="https://github.com/microsoft/semantic-kernel/assets/51973971/50c37abf-a59e-41e8-a42b-ada975802344"> **Note:** This also involves changes to the semantic kernel, therefore it will be available when new nuget packages are published. Until then you will have to change .\samples\apps\copilot-chat-app\webapi\CopilotChatWebApi.csproj manually to load project reference instead of the respective package references to see this change.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…#1083) ### Motivation and Context Improve error messages displayed in copliot chat front end. <img width="1917" alt="betterErrorResponse" src="https://github.com/microsoft/semantic-kernel/assets/51973971/50c37abf-a59e-41e8-a42b-ada975802344"> **Note:** This also involves changes to the semantic kernel, therefore it will be available when new nuget packages are published. Until then you will have to change .\samples\apps\copilot-chat-app\webapi\CopilotChatWebApi.csproj manually to load project reference instead of the respective package references to see this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improve error messages displayed in copliot chat front end.
Note: This also involves changes to the semantic kernel, therefore it will be available when new nuget packages are published. Until then you will have to change .\samples\apps\copilot-chat-app\webapi\CopilotChatWebApi.csproj manually to load project reference instead of the respective package references to see this change.
Contribution Checklist
dotnet format