Repository navigation
Add debugger displays and type proxies for core abstraction types - #1080
Merged
Shawn Callegari (shawncal) merged 12 commits intoMay 20, 2023
Merged
Conversation
github-actions
Bot
added
.NET
Lee Miller (lemillermicrosoft)
previously approved these changes
May 19, 2023
Lee Miller (lemillermicrosoft)
left a comment
Lee Miller (lemillermicrosoft)
left a comment
Member
There was a problem hiding this comment.
This is cool! I might add similar to Plan object. Curious if you have any thoughts/consideration there.
Lee Miller (lemillermicrosoft)
added
PR: ready for review
Member
Author
I've pushed another commit to add a debugger display for plan. Obviously this and any other one I've added can be tweaked to ensure the most useful information is highlighted. Before 
After 
|
Lee Miller (lemillermicrosoft)
previously approved these changes
May 19, 2023
Lee Miller (lemillermicrosoft)
left a comment
Lee Miller (lemillermicrosoft)
left a comment
Member
There was a problem hiding this comment.
Thanks for adding Plan changes!
Shawn Callegari (shawncal)
previously approved these changes
May 20, 2023
Shawn Callegari (shawncal)
dismissed stale reviews from Lee Miller (lemillermicrosoft) and themself
via
May 20, 2023 05:19
abb651d
Contributor
|
Merged main, resolved (in browser) then had to fix a dotnet format whitespace thing. |
Shawn Callegari (shawncal)
approved these changes
May 20, 2023
Shawn Callegari (shawncal)
enabled auto-merge (squash)
May 20, 2023 05:25
Shawn Callegari (shawncal)
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…crosoft#1080) ### Motivation and Context Make it easier to examine core state while debugging with semantic kernel. ### Description While debugging through examples to better understand the whole model, I found myself routinely diving into various data structures to find the information I wanted to see. I've added [DebuggerDisplay] and [DebuggerTypeProxy] attributes to surface the most relevant information. I view this as a starting point; hopefully folks like this and will replicate it onto other types of relevance. Example Before  Example After <img width="426" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/2642209/1ab6514a-7333-441f-bc5a-b2fb6e4d26ff"> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 cc: @shawncal --------- Co-authored-by: Lee Miller <[email protected]> Co-authored-by: Shawn Callegari <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Make it easier to examine core state while debugging with semantic kernel.
Description
While debugging through examples to better understand the whole model, I found myself routinely diving into various data structures to find the information I wanted to see. I've added [DebuggerDisplay] and [DebuggerTypeProxy] attributes to surface the most relevant information. I view this as a starting point; hopefully folks like this and will replicate it onto other types of relevance.
Example Before
Example After
Contribution Checklist
dotnet formatcc: Shawn Callegari (@shawncal)