Skip to content

.Net: SK integration with MEAI Abstractions (Service Selector + Contents) Phase 1 - #10651

Merged
Roger Barreto (rogerbarreto) merged 31 commits into
microsoft:feature-msextensions-aifrom
rogerbarreto:issues/10319-sk-meai-integration
Mar 3, 2025
Merged

.Net: SK integration with MEAI Abstractions (Service Selector + Contents) Phase 1#10651
Roger Barreto (rogerbarreto) merged 31 commits into
microsoft:feature-msextensions-aifrom
rogerbarreto:issues/10319-sk-meai-integration

Conversation

@rogerbarreto

@rogerbarreto Roger Barreto (rogerbarreto) commented Feb 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation and Context

This change adds a new IChatClientSelector abstraction to work without breaking current IAIServiceSelector implementations.

This was necessary because Kernel now will be able to resolve IChatClients which are not IAIService implementations, and OrderedAIServiceSelector now can select not only AIServices but ChatClients as well by implementing the IChatClientSelector interface.

All other changes are related to test accepting IChatClients added to the Service DI container, ensuring they work as expected together with current IChatCOmpletionService and ITextGenerationService in the Kernel.

@rogerbarreto Roger Barreto (rogerbarreto) added the .NET Issue or Pull requests regarding .NET code label Feb 24, 2025
stephentoub
Stephen Toub (stephentoub) reviewed Feb 24, 2025
View reviewed changes
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/ChatClientAIService.cs Resolved
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/ChatClientExtensions.cs Resolved
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/ChatMessageExtensions.cs Resolved
Comment thread dotnet/src/SemanticKernel.Abstractions/Services/OrderedAIServiceSelector.cs Resolved
Comment thread dotnet/src/SemanticKernel.Core/Functions/KernelFunctionFromPrompt.cs Resolved
Comment thread dotnet/src/SemanticKernel.Core/Functions/KernelFunctionFromPrompt.cs Resolved
Comment thread dotnet/src/SemanticKernel.Core/Functions/KernelFunctionFromPrompt.cs Resolved
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added kernel Issues or pull requests impacting the core kernel kernel.core labels Feb 26, 2025
@rogerbarreto
Roger Barreto (rogerbarreto) marked this pull request as ready for review February 26, 2025 19:56
dmytrostruk
Dmytro Struk (dmytrostruk) approved these changes Feb 27, 2025
View reviewed changes
Comment thread dotnet/samples/Concepts/Kernel/CustomAIServiceSelector.cs Resolved
Comment thread dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAIChatCompletionTests.cs Resolved
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatHistoryExtensions.cs Resolved
Comment thread dotnet/src/SemanticKernel.Abstractions/Services/IServiceSelector.cs Resolved
Comment thread dotnet/src/SemanticKernel.UnitTests/Functions/OrderedAIServiceSelectorTests.cs Resolved
@rogerbarreto
Roger Barreto (rogerbarreto) merged commit 908333b into microsoft:feature-msextensions-ai Mar 3, 2025
@rogerbarreto Roger Barreto (rogerbarreto) mentioned this pull request Mar 3, 2025
Merged

This branch was previously deployed

1 inactive deployment
integration — c7fb8cdf Deployed Mar 3, 2025 by rogerbarreto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub Stephen Toub (stephentoub) stephentoub left review comments
@SergeyMenshykh SergeyMenshykh SergeyMenshykh left review comments
@dmytrostruk Dmytro Struk (dmytrostruk) dmytrostruk approved these changes
+2 more reviewers
@markwallace-microsoft Mark Wallace (markwallace-microsoft) markwallace-microsoft left review comments
@shethaadit Adit Sheth (shethaadit) shethaadit approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rogerbarreto Roger Barreto (rogerbarreto)

Labels

kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rogerbarreto @stephentoub @shethaadit @dmytrostruk @SergeyMenshykh @markwallace-microsoft