Repository navigation
Hotfix - ChatCompletionImpl as ITextCompletion Regression Fix and Added Tests - #1062
Merged
Adrian Bonar (adrianwyatt) merged 11 commits intoMay 18, 2023
Conversation
github-actions
Bot
added
.NET
Roger Barreto (rogerbarreto)
requested review from
Devis Lucato (dluc) and
Shawn Callegari (shawncal)
May 18, 2023 10:54
Roger Barreto (rogerbarreto)
added
bug
Adrian Bonar (adrianwyatt)
previously approved these changes
May 18, 2023
Lee Miller (lemillermicrosoft)
approved these changes
May 18, 2023
5 tasks done
Shawn Callegari (shawncal)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…ed Tests (microsoft#1062) ### Motivation and Context With the most recent changes in ITextCompletion interface a small regression was introduced in the Chat Completion implementation of both OpenAI/AzureOpenAI where they were not calling the Chat completion endpoints but the text ones for a Chat Model. ### Description - Fix for the current implementaions - Added new Integration Tests to ensure this regression won't happen again. - Added configuration detail for Chat model for OpenAI and AzureOpenAi: `ChatModelId`, `ChatDeploymentName` respectively. - Updated IT Tests Readme. -⚠️ This change adds gpt-4 model as part of our default configuration for chat as text integration tests
Roger Barreto (rogerbarreto)
deleted the
hotfix/addazurechatcompletion-fix
branch
December 5, 2023 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With the most recent changes in ITextCompletion interface a small regression was introduced in the Chat Completion implementation of both OpenAI/AzureOpenAI where they were not calling the Chat completion endpoints but the text ones for a Chat Model.
Description
ChatModelId,ChatDeploymentNamerespectively.Contribution Checklist
dotnet format