Repository navigation
Improvements to SKFunction interface - #1060
Merged
Merged
Conversation
Devis Lucato (dluc)
commented
May 18, 2023
Devis Lucato (dluc)
commented
Contributor
- Allow to call functions passing a string. This is a common scenario, particularly with demos, allowing for a shorter syntax. The code logs a warning if the input string exists also in the context and is different.
- Add SKContext.Clone and delete unnecessary/redundant SKFunction.InvokeWithCustomInput method.
- Allow to create a context with a non empty cancellation token. This can be useful to inject an existing token from outside.
- Fix SKFunction invoke, allow to pass memory reference.
github-actions
Bot
added
.NET
Devis Lucato (dluc)
added
the
PR: ready for review
Devis Lucato (dluc)
force-pushed
the
dluc157ifaces
branch
from
May 18, 2023 08:39
a46c5cb to
81ba077
Compare
Devis Lucato (dluc)
force-pushed
the
dluc157ifaces
branch
2 times, most recently
from
May 18, 2023 08:50
5ca6c5a to
8065d99
Compare
Devis Lucato (dluc)
force-pushed
the
dluc157ifaces
branch
3 times, most recently
from
May 18, 2023 16:08
0deb536 to
784df46
Compare
Devis Lucato (dluc)
force-pushed
the
dluc157ifaces
branch
2 times, most recently
from
May 19, 2023 00:10
48cee92 to
636fc38
Compare
Devis Lucato (dluc)
force-pushed
the
dluc157ifaces
branch
3 times, most recently
from
May 19, 2023 07:49
c1abe16 to
44caf1f
Compare
Lee Miller (lemillermicrosoft)
added
PR: in progress
Devis Lucato (dluc)
force-pushed
the
dluc157ifaces
branch
2 times, most recently
from
May 19, 2023 19:39
dc732fa to
713ad12
Compare
* Allow to create a context with a non empty cancellation token * Fix SKFunction invoke, allow to pass memory reference * Delete unnecessary SKFunction.InvokeWithCustomInput
Devis Lucato (dluc)
force-pushed
the
dluc157ifaces
branch
from
May 19, 2023 20:03
713ad12 to
bc28185
Compare
Shawn Callegari (shawncal)
approved these changes
May 19, 2023
Shawn Callegari (shawncal)
approved these changes
May 19, 2023
Shawn Callegari (shawncal)
added
the
PR: ready to merge
Shawn Callegari (shawncal)
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
* Allow to call functions passing a string. This is a common scenario, particularly with demos, allowing for a shorter syntax. The code logs a warning if the input string exists also in the context and is different. * Add SKContext.Clone and delete unnecessary/redundant SKFunction.InvokeWithCustomInput method. * Allow to create a context with a non empty cancellation token. This can be useful to inject an existing token from outside. * Fix SKFunction invoke, allow to pass memory reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.