Skip to content

Fix delegate_inference.py - #1054

Merged
Lee Miller (lemillermicrosoft) merged 2 commits into
microsoft:mainfrom
salmon131:main
May 19, 2023
Merged

Fix delegate_inference.py#1054
Lee Miller (lemillermicrosoft) merged 2 commits into
microsoft:mainfrom
salmon131:main

Conversation

@salmon131

@salmon131 hyunyoungjin (salmon131) commented May 18, 2023

Copy link
Copy Markdown
Contributor

Motivation and Context

#691
#1053

Description

  1. Added an argument to prevent TypeError when inferring an unknown type.
  2. Fixed a bug in the process of checking parameters when inferring the InStringAndContext type.

Contribution Checklist

@github-actions github-actions Bot added the python Pull requests for the Python Semantic Kernel label May 18, 2023
@alexchaomander Alex Chao (alexchaomander) added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 19, 2023
alexchaomander
Alex Chao (alexchaomander) approved these changes May 19, 2023
View reviewed changes

@alexchaomander Alex Chao (alexchaomander) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this fix!

@lemillermicrosoft
Lee Miller (lemillermicrosoft) merged commit a3d2224 into microsoft:main May 19, 2023
Shawn Callegari (shawncal) pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@salmon131 name
Fix delegate_inference.py (microsoft#1054)
b034273 
### Motivation and Context
microsoft#691 
microsoft#1053 

### Description
1. Added an argument to prevent TypeError when inferring an unknown
type.
2. Fixed a bug in the process of checking parameters when inferring the
InStringAndContext type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mkarle Mark Karle (mkarle) mkarle approved these changes
@alexchaomander Alex Chao (alexchaomander) alexchaomander approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@salmon131 @mkarle @alexchaomander @lemillermicrosoft