Repository navigation
Python: [python] Bug fix 10340 - #10341
Merged
Merged
Conversation
Mark Wallace (markwallace-microsoft)
added
the
python
github-actions
Bot
changed the title
Tao Chen (TaoChenOSU)
approved these changes
Jan 29, 2025
Evan Mattson (moonbox3)
approved these changes
Jan 29, 2025
Evan Mattson (moonbox3)
left a comment
Evan Mattson (moonbox3)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR!
Collaborator
|
Drew Parker (@drdrew42) could you please add a quick unit test so we have coverage? We're lacking test coverage as we're not catching these small items. |
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
Contributor
Author
|
@microsoft-github-policy-service agree company="SandboxAQ" |
Evan Mattson (moonbox3)
approved these changes
Jan 30, 2025
Evan Mattson (moonbox3)
enabled auto-merge
January 30, 2025 23:56
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 31, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 31, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 31, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jan 31, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
### Motivation and Context See microsoft#10340 ### Description Implement a similar approach as is done in `process_step_edge_builder.py`, which supports function_name when building the target function. ### Contribution Checklist - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 (well, we're still passing/xpass/xfail the same as main is) --------- Co-authored-by: Evan Mattson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See #10340
Description
Implement a similar approach as is done in
process_step_edge_builder.py, which supports function_name when building the target function.Contribution Checklist
(well, we're still passing/xpass/xfail the same as main is)