Repository navigation
Fix code style and xmldocs, add Roslynator analyzer - #1030
Merged
Merged
Conversation
Devis Lucato (dluc)
force-pushed
the
dluc156cs
branch
2 times, most recently
from
May 17, 2023 01:55
1abc3b6 to
55e4d2a
Compare
Harleen Thind (hathind-ms)
previously approved these changes
May 17, 2023
Devis Lucato (dluc)
force-pushed
the
dluc156cs
branch
2 times, most recently
from
May 17, 2023 02:36
9adbc4c to
2015019
Compare
Devis Lucato (dluc)
force-pushed
the
dluc156cs
branch
from
May 17, 2023 02:45
2015019 to
4ef50ec
Compare
Shawn Callegari (shawncal)
previously approved these changes
May 17, 2023
Stephen Toub (stephentoub)
previously approved these changes
May 17, 2023
Devis Lucato (dluc)
dismissed stale reviews from Stephen Toub (stephentoub) and Shawn Callegari (shawncal)
via
May 17, 2023 17:34
c9005b5
Devis Lucato (dluc)
force-pushed
the
dluc156cs
branch
4 times, most recently
from
May 17, 2023 18:11
d3c3aac to
6c1a398
Compare
Devis Lucato (dluc)
force-pushed
the
dluc156cs
branch
from
May 17, 2023 18:31
6c1a398 to
b7ccd2f
Compare
Devis Lucato (dluc)
force-pushed
the
dluc156cs
branch
from
May 17, 2023 18:40
b7ccd2f to
52ba4cd
Compare
Harleen Thind (hathind-ms)
approved these changes
May 17, 2023
Shawn Callegari (shawncal)
approved these changes
May 17, 2023
5 tasks done
Shawn Callegari (shawncal)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
Add [Roslynator](https://github.com/JosefPihrt/Roslynator) and fix some code style issues found. `dotnet_analyzer_diagnostic.severity` is set to `none` to stop `dotnet format` from editing a lot of files, even unrelated issues, probably detected by other analyzers, and a lot of issues are disabled. Currently only these are enabled: ``` dotnet_diagnostic.RCS1036.severity = warning # Remove unnecessary blank line. dotnet_diagnostic.RCS1037.severity = warning # Remove trailing white-space. dotnet_diagnostic.RCS1097.severity = warning # Remove redundant 'ToString' call. dotnet_diagnostic.RCS1138.severity = warning # Add summary to documentation comment. dotnet_diagnostic.RCS1168.severity = warning # Parameter name 'foo' differs from base name 'bar'. dotnet_diagnostic.RCS1175.severity = warning # Unused 'this' parameter 'operation'. dotnet_diagnostic.RCS1192.severity = warning # Unnecessary usage of verbatim string literal. dotnet_diagnostic.RCS1139.severity = warning # Add summary element to documentation comment. dotnet_diagnostic.RCS1211.severity = warning # Remove unnecessary else clause. dotnet_diagnostic.RCS1214.severity = warning # Unnecessary interpolated string. dotnet_diagnostic.RCS1225.severity = warning # Make class sealed. dotnet_diagnostic.RCS1232.severity = warning # Order elements in documentation comment. ``` Note: * There are a lot more issues to fix, for now I disabled a lot of checks and fixed only a bunch. * Future: enable more of `dotnet_diagnostic.RCS` currently disabled, e.g. XMLDoc checks, to get better code docs Other fixes: * fix incorrect namespaces in copilot chat * use static property for regex * typos, missing copyright * switch from CA1032 to RCS1194 to cover more exception ctors
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
Add [Roslynator](https://github.com/JosefPihrt/Roslynator) and fix some code style issues found. `dotnet_analyzer_diagnostic.severity` is set to `none` to stop `dotnet format` from editing a lot of files, even unrelated issues, probably detected by other analyzers, and a lot of issues are disabled. Currently only these are enabled: ``` dotnet_diagnostic.RCS1036.severity = warning # Remove unnecessary blank line. dotnet_diagnostic.RCS1037.severity = warning # Remove trailing white-space. dotnet_diagnostic.RCS1097.severity = warning # Remove redundant 'ToString' call. dotnet_diagnostic.RCS1138.severity = warning # Add summary to documentation comment. dotnet_diagnostic.RCS1168.severity = warning # Parameter name 'foo' differs from base name 'bar'. dotnet_diagnostic.RCS1175.severity = warning # Unused 'this' parameter 'operation'. dotnet_diagnostic.RCS1192.severity = warning # Unnecessary usage of verbatim string literal. dotnet_diagnostic.RCS1139.severity = warning # Add summary element to documentation comment. dotnet_diagnostic.RCS1211.severity = warning # Remove unnecessary else clause. dotnet_diagnostic.RCS1214.severity = warning # Unnecessary interpolated string. dotnet_diagnostic.RCS1225.severity = warning # Make class sealed. dotnet_diagnostic.RCS1232.severity = warning # Order elements in documentation comment. ``` Note: * There are a lot more issues to fix, for now I disabled a lot of checks and fixed only a bunch. * Future: enable more of `dotnet_diagnostic.RCS` currently disabled, e.g. XMLDoc checks, to get better code docs Other fixes: * fix incorrect namespaces in copilot chat * use static property for regex * typos, missing copyright * switch from CA1032 to RCS1194 to cover more exception ctors
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Add [Roslynator](https://github.com/JosefPihrt/Roslynator) and fix some code style issues found. `dotnet_analyzer_diagnostic.severity` is set to `none` to stop `dotnet format` from editing a lot of files, even unrelated issues, probably detected by other analyzers, and a lot of issues are disabled. Currently only these are enabled: ``` dotnet_diagnostic.RCS1036.severity = warning # Remove unnecessary blank line. dotnet_diagnostic.RCS1037.severity = warning # Remove trailing white-space. dotnet_diagnostic.RCS1097.severity = warning # Remove redundant 'ToString' call. dotnet_diagnostic.RCS1138.severity = warning # Add summary to documentation comment. dotnet_diagnostic.RCS1168.severity = warning # Parameter name 'foo' differs from base name 'bar'. dotnet_diagnostic.RCS1175.severity = warning # Unused 'this' parameter 'operation'. dotnet_diagnostic.RCS1192.severity = warning # Unnecessary usage of verbatim string literal. dotnet_diagnostic.RCS1139.severity = warning # Add summary element to documentation comment. dotnet_diagnostic.RCS1211.severity = warning # Remove unnecessary else clause. dotnet_diagnostic.RCS1214.severity = warning # Unnecessary interpolated string. dotnet_diagnostic.RCS1225.severity = warning # Make class sealed. dotnet_diagnostic.RCS1232.severity = warning # Order elements in documentation comment. ``` Note: * There are a lot more issues to fix, for now I disabled a lot of checks and fixed only a bunch. * Future: enable more of `dotnet_diagnostic.RCS` currently disabled, e.g. XMLDoc checks, to get better code docs Other fixes: * fix incorrect namespaces in copilot chat * use static property for regex * typos, missing copyright * switch from CA1032 to RCS1194 to cover more exception ctors
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Add [Roslynator](https://github.com/JosefPihrt/Roslynator) and fix some code style issues found. `dotnet_analyzer_diagnostic.severity` is set to `none` to stop `dotnet format` from editing a lot of files, even unrelated issues, probably detected by other analyzers, and a lot of issues are disabled. Currently only these are enabled: ``` dotnet_diagnostic.RCS1036.severity = warning # Remove unnecessary blank line. dotnet_diagnostic.RCS1037.severity = warning # Remove trailing white-space. dotnet_diagnostic.RCS1097.severity = warning # Remove redundant 'ToString' call. dotnet_diagnostic.RCS1138.severity = warning # Add summary to documentation comment. dotnet_diagnostic.RCS1168.severity = warning # Parameter name 'foo' differs from base name 'bar'. dotnet_diagnostic.RCS1175.severity = warning # Unused 'this' parameter 'operation'. dotnet_diagnostic.RCS1192.severity = warning # Unnecessary usage of verbatim string literal. dotnet_diagnostic.RCS1139.severity = warning # Add summary element to documentation comment. dotnet_diagnostic.RCS1211.severity = warning # Remove unnecessary else clause. dotnet_diagnostic.RCS1214.severity = warning # Unnecessary interpolated string. dotnet_diagnostic.RCS1225.severity = warning # Make class sealed. dotnet_diagnostic.RCS1232.severity = warning # Order elements in documentation comment. ``` Note: * There are a lot more issues to fix, for now I disabled a lot of checks and fixed only a bunch. * Future: enable more of `dotnet_diagnostic.RCS` currently disabled, e.g. XMLDoc checks, to get better code docs Other fixes: * fix incorrect namespaces in copilot chat * use static property for regex * typos, missing copyright * switch from CA1032 to RCS1194 to cover more exception ctors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Roslynator and fix some code style issues found.
dotnet_analyzer_diagnostic.severityis set tononeto stopdotnet formatfrom editing a lot of files, even unrelated issues, probably detected by other analyzers, and a lot of issues are disabled. Currently only these are enabled:Note:
dotnet_diagnostic.RCScurrently disabled, e.g. XMLDoc checks, to get better code docsOther fixes: