Skip to content

.Net: OpenAPI description parsing only considers operation path parameters #9962

New issue
New issue
Closed
#9969
Closed
.Net: OpenAPI description parsing only considers operation path parameters#9962
#9969
Assignees
baywetmarkwallace-microsoft
Labels
.NETIssue or Pull requests regarding .NET code

Description

@baywet
Vincent Biret (baywet)
opened on Dec 12, 2024

semantic-kernel/dotnet/src/Functions/Functions.OpenApi/OpenApi/OpenApiDocumentParser.cs

Line 214 in b40e0cc

parameters: CreateRestApiOperationParameters(operationItem.OperationId, operationItem.Parameters),

It does not look at path item defined path parameters, and that makes the function definition incomplete/failing.

Reference (see the parameters property in the fixed fields).

You can assign this issue to me, I'll be submitting a PR to address that within a couple of days.

Activity

  1. Mark Wallace (markwallace-microsoft)
    added
    .NETIssue or Pull requests regarding .NET code
    triage
    on Dec 12, 2024
  2. github-actions
    changed the title [-]OpenAPI description parsing only considers operation path parameters[/-] [+].Net: OpenAPI description parsing only considers operation path parameters[/+] on Dec 12, 2024

  3. baywet commented on Dec 13, 2024

    @baywet
    Vincent Biret (baywet)
    on Dec 13, 2024
    MemberAuthor

    put together #9969

  4. Mark Wallace (markwallace-microsoft)
    assigned
    Vincent Biret (baywet)
    on Dec 13, 2024
  5. Mark Wallace (markwallace-microsoft)
    added this to Semantic Kernelon Dec 13, 2024
  6. Mark Wallace (markwallace-microsoft)
    moved this to Community PRs in Semantic Kernelon Dec 13, 2024
  7. Mark Wallace (markwallace-microsoft)
    self-assigned this
    on Dec 13, 2024
  8. Mark Wallace (markwallace-microsoft)
    removed
    triage
    on Dec 16, 2024
  9. github-merge-queue
    added a commit that references this issue on Dec 16, 2024

    .Net: fix: includes path item path parameters to OpenAPI document par…

    5874188
  10. Mark Wallace (markwallace-microsoft)
    closed this as completedin #9969on Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

.NETIssue or Pull requests regarding .NET code

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions