Repository navigation
python: prompt_template_config need change #309
Description
Describe the bug
use import_semantic_skill_from_directory(kernel, skill_dir, skill) function and if its config has no stop_sequence in it,
will raise error if its skill is really used by kernel.
I'll open PR, and this bug only need one line changed. see you at PR
To Reproduce
use import_semantic_skill_from_directory(kernel, skill_dir, skill)
and use skill with it.
Expected behavior
even though user didn't provide stop_sequence in config.json, it should be run anyway
Screenshots
check screenshot above
Desktop (please complete the following information):
- OS: Mac M1
- IDE: VS code
- python 3.11
Additional context
Add any other context about the problem here.
Activity
jjhenkel commentedon Apr 4, 2023
Thanks for this! I think I just ran into the same thing (and have a separate fix for it, but we should fix it in both places): see this PR.
fix: add missing default value (#310)
jjhenkel commentedon Apr 6, 2023
Alex Chao (@alexchaomander) I think we can close this now, our fix was merged earlier and now Joowon (@joowon-dm-snu)'s fix is merged as well. (Doubly fixed!)
fix: add missing default value (#310)
fix: add missing default value (#310)
fix: add missing default value (#310)
fix: add missing default value (microsoft#310)