Skip to content

Java: minRelevanceScore on memory API should be float #2514

@dsgrieve

Description

@dsgrieve

minRelevanceScore is a double. cosineSimilarity returns a float. minRelevanceScore should also be a float.

At a minimum, the code that casts the double cosineSimilarity to a float should bound the cast to Float.MAX_VALUE.

Metadata

Metadata

Assignees

Labels

javaIssue or PR regarding Java code

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions