The Builder interface has two methods, one starting with with and the other one with set:
interface Builder extends SemanticKernelBuilder<ChatCompletion> {
Builder withOpenAIClient(OpenAIAsyncClient client);
Builder setModelId(String modelId);
}This is confusing because most of the build methods start with with and not set. For example withDefaultAIService, withOpenAIClient but setModelId:
Kernel kernel = SKBuilders.kernel()
.withDefaultAIService(SKBuilders.textCompletionService()
.setModelId("text-davinci-003")
.withOpenAIClient(client)
.build())
.build();It will feel more natural to have with on both methods. WDYT?
interface Builder extends SemanticKernelBuilder<ChatCompletion> {
Builder withOpenAIClient(OpenAIAsyncClient client);
Builder withModelId(String modelId);
}PS: somehow related to #2436
The
Builderinterface has two methods, one starting withwithand the other one withset:This is confusing because most of the build methods start with
withand notset. For examplewithDefaultAIService,withOpenAIClientbutsetModelId:It will feel more natural to have
withon both methods. WDYT?PS: somehow related to #2436