Skip to content

Java: Naming conventions in SKBuilders class #2436

@agoncal

Description

@agoncal

When using the SKBuilders class I find myself getting confused with "what is a service and what is not?". Basically, the chatCompletion method returns a ChatCompletion and the method is called chatCompletion. But, the textCompletionService method returns a TextCompletion but is suffixed with Service:

public class SKBuilders {

  public static TextCompletion.Builder textCompletionService()
  public static ChatCompletion.Builder chatCompletion()
  public static EmbeddingGeneration.Builder<String> textEmbeddingGenerationService()

}

Shouldn't Service be abandoned and just have:

public class SKBuilders {

  public static TextCompletion.Builder textCompletion()
  public static ChatCompletion.Builder chatCompletion()
  public static EmbeddingGeneration.Builder<String> textEmbeddingGeneration()

}

PS: somehow related to #2437

Metadata

Metadata

Assignees

Labels

javaIssue or PR regarding Java codesk team issueA tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions