Repository navigation
import_semantic_skill_from_directory is not assigning config #235
Description
Describe the bug
import_semantic_skill_from_directory is not reassigning the values with the result of the config.from_json(config_file.read()) call resulting in an empty config.
Easy fix is to just change line 45 to
config = config.from_json(config_file.read())
To Reproduce
Steps to reproduce the behavior:
- Set a debugger here in the IDE.
- Run the following in Debug mode on IDE
import semantic_kernel as sk
from semantic_kernel.kernel_extensions.import_semantic_skill_from_directory import import_semantic_skill_from_directory
#create a kernel
kernel = sk.KernelBuilder.create_kernel()
#import skills
skills_directory = "../../skills" #path to skills directory
skill = import_semantic_skill_from_directory(kernel, skills_directory, "SummarizeSkill")
- Look at the
configobject. Notice there's no description or default backends.
Expected behavior
config object has info from the json file such as description and default_backends.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: Windows
- IDE: PyCharm
Activity
renrut commentedon Mar 30, 2023
I can open a PR for it in a few.
renrut commentedon Mar 30, 2023
Looks like there's a typo here as well. Will fix in same pr...
https://github.com/microsoft/semantic-kernel/blob/python-preview/python/semantic_kernel/semantic_functions/prompt_template_config.py#L43
evchaki commentedon Mar 30, 2023
Thanks for doing this!
Fix import_semantic_skill_from_directory (#236)
renrut commentedon Apr 4, 2023
Can close with #236
Fix import_semantic_skill_from_directory (#236)
Fix import_semantic_skill_from_directory (#236)
Fix import_semantic_skill_from_directory (#236)
Fix import_semantic_skill_from_directory (microsoft#236)
Add missing step to README instructions for enabling auth (microsoft#235