Repository navigation
skills are not working in PromptTemplate (python-3.9) #182
Description
Describe the bug
After learning from the last issue that compatibility with 3.9 was not robust,
I rerun the memory skill part and realized that it was not working properly.
This error is silent because PromptTemplateEngine is using invoke_with_custom_iunput_async function that contains try-exception code for rendering blocks.
originally it should show this error
DelegateHandlers.get_handler(self._delegate_type)
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/Users/joowonkim/Repo/semantic-kernel-jw/semantic-kernel/python/semantic_kernel/orchestration/delegate_handlers.py", line 155, in get_handler
value.__wrapped__, "_delegate_type"
AttributeError: 'staticmethod' object has no attribute '__wrapped__'
similar with #168 semantic-kernel/python/semantic_kernel/orchestration/delegate_handlers.py needs change.
To Reproduce
runsemantic-kernel/python/tests/memory.py
Expected behavior
PromptTemplateEngine render blocks correctly
Screenshots
Desktop (please complete the following information):
- OS: Mac M1
- IDE: VS code
- Python: 3.9.13
Additional context
Add any other context about the problem here.
Activity
joowon-dm-snu commentedon Mar 28, 2023
while fixing this issue. i find out
staticmethodis not callable in python3.9. need to handle it too.alexchaomander commentedon Mar 28, 2023
Thank you for finding these issues across the different Python versions!
jjhenkel commentedon Mar 28, 2023
Agreed! We may want to decide sooner rather than later on a minimum supported version (which we should discuss) but, regardless, knowing a bit more about possible cross-version issues is a huge help so thank you Joowon (@joowon-dm-snu) !
fix: delegate compatibility issue for python 3.9 (#183)
alexchaomander commentedon Mar 29, 2023
Merged!
fix: delegate compatibility issue for python 3.9 (#183)
fix: delegate compatibility issue for python 3.9 (#183)
fix: delegate compatibility issue for python 3.9 (#183)
fix: delegate compatibility issue for python 3.9 (microsoft#183)
Re-ordered plug-in result to be included _after_ chat-history (micros…