Skip to content

.Net: [MEVD] Ensure Contains compatibility with C# 14 first-class spans #12504

New issue
New issue
Closed
Bug
#13263
Closed
.Net: [MEVD] Ensure Contains compatibility with C# 14 first-class spans#12504
Bug
#13263
Assignees
roji
Labels
.NETIssue or Pull requests regarding .NET codemsft.ext.vectordataRelated to Microsoft.Extensions.VectorData

Description

@roji
Shay Rojansky (roji)
opened on Jun 17, 2025

C# 14 is bringing first-class spans, which changes the compiler resolution of method invocations, causes MemoryExtensions.Contains() (accepting spans) to be resolved instead of the traditional Enumerable.Contains. This can cause issues with LINQ providers, and likely would need reacting to in MEVD LINQ filters as well. We can integrate this logic into the FilterTranslationPreprocessor.

See dotnet/runtime#109757, and on the EF side, dotnet/efcore#35547 and dotnet/efcore#35100

Activity

  1. Shay Rojansky (roji)
    self-assigned this
    on Jun 17, 2025
  2. Shay Rojansky (roji)
    added the
    Bug
    issue type on Jun 17, 2025
  3. Shay Rojansky (roji)
    added
    .NETIssue or Pull requests regarding .NET code
    msft.ext.vectordataRelated to Microsoft.Extensions.VectorData
    on Jun 17, 2025
  4. Shay Rojansky (roji)
    added this to Semantic Kernelon Jun 17, 2025
  5. Shay Rojansky (roji)
    moved this to Backlog: Planned in Semantic Kernelon Jun 17, 2025
  6. Mark Wallace (markwallace-microsoft)
    added
    triage
    on Jun 17, 2025
  7. github-actions
    changed the title [-][MEVD] Ensure Contains compatibility with C# 14 first-class spans[/-] [+].Net: [MEVD] Ensure Contains compatibility with C# 14 first-class spans[/+] on Jun 17, 2025
  8. Mark Wallace (markwallace-microsoft)
    removed
    triage
    on Jun 18, 2025

  9. github-actions commented on Sep 17, 2025

    @github-actions
    github-actionsBot
    on Sep 17, 2025 – with GitHub Actions
    Contributor

    This issue is stale because it has been open for 90 days with no activity.

  10. github-actions
    added
    staleIssue is stale because it has been open for a while and has no activity
    on Sep 17, 2025
  11. Shay Rojansky (roji)
    removed
    staleIssue is stale because it has been open for a while and has no activity
    on Sep 19, 2025
  12. Shay Rojansky (roji)
    moved this from Backlog: Planned to Sprint: In Progress in Semantic Kernelon Oct 19, 2025
  13. Shay Rojansky (roji)
    added 2 commits that reference this issue on Oct 19, 2025

    Support MemoryExtensions.Contains in LINQ filters

    a236b0b

    Support MemoryExtensions.Contains in LINQ filters

    d39b950
  14. Shay Rojansky (roji)
    moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernelon Oct 19, 2025
  15. Shay Rojansky (roji)
    added a commit that references this issue on Oct 22, 2025

    Support MemoryExtensions.Contains in LINQ filters

    fcf05ad
  16. github-merge-queue
    added a commit that references this issue on Oct 23, 2025

    .Net: [MEVD] Support MemoryExtensions.Contains in LINQ filters (#13263)

    1761c68
  17. Shay Rojansky (roji)
    closed this as completedin #13263on Oct 23, 2025
  18. westey (westey-m)
    moved this from Sprint: In Review to Sprint: Done in Semantic Kernelon Oct 23, 2025
  19. Alexander Zarei (alzarei)
    added 3 commits that reference this issue on Oct 29, 2025

    feat: Add C# 14 MemoryExtensions.Contains support to BingTextSearch

    db5c9a2

    feat: Add C# 14 MemoryExtensions.Contains support to BingTextSearch

    dfb589d

    feat: Add C# 14 MemoryExtensions.Contains support to BingTextSearch

    1749345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

.NETIssue or Pull requests regarding .NET codemsft.ext.vectordataRelated to Microsoft.Extensions.VectorData

Type

Bug

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions