Skip to content

.Net: [MEVD] IVectorStore implementations should return the concrete collection types #11759

New issue
New issue
Closed
Closed
.Net: [MEVD] IVectorStore implementations should return the concrete collection types#11759
Assignees
roji
Labels
.NETIssue or Pull requests regarding .NET codeBuildFeatures planned for next Build conferencemsft.ext.vectordataRelated to Microsoft.Extensions.VectorData

Description

@roji
Shay Rojansky (roji)
opened on Apr 27, 2025

PostgresVectorStore.GetCollection() currently returns the abstraction interface IVectorStoreRecordCollection<TKey, TRecord>; if a user then wishes to use a PG-specific API on the collection, they then must downcast the interface. This makes it awkward to both use the IVectorStore implementation (as a factory for collection instances) and use connector-specific APIs.

We can simply have GetCollection() return a PostgresVectorStoreRecordCollection, and have an explicit interface implementation to implement the required IVectorStore interface method.

Activity

  1. Shay Rojansky (roji)
    added
    .NETIssue or Pull requests regarding .NET code
    BuildFeatures planned for next Build conference
    msft.ext.vectordataRelated to Microsoft.Extensions.VectorData
    on Apr 27, 2025
  2. Shay Rojansky (roji)
    self-assigned this
    on Apr 27, 2025
  3. Shay Rojansky (roji)
    added this to Semantic Kernelon Apr 27, 2025
  4. Shay Rojansky (roji)
    moved this to Backlog: Planned in Semantic Kernelon Apr 27, 2025
  5. github-actions
    changed the title [-][MEVD] IVectorStore implementations should return the concrete collection types[/-] [+].Net: [MEVD] IVectorStore implementations should return the concrete collection types[/+] on Apr 27, 2025
  6. Mark Wallace (markwallace-microsoft)
    added
    triage
    on Apr 27, 2025
  7. Shay Rojansky (roji)
    removed
    triage
    on Apr 27, 2025
  8. Shay Rojansky (roji)
    added a commit that references this issue on May 4, 2025

    Add covariant return types to VectorStore.GetCollection() implementat…

    4360b38
  9. Shay Rojansky (roji)
    moved this from Backlog: Planned to Sprint: In Review in Semantic Kernelon May 4, 2025
  10. Shay Rojansky (roji)
    added 3 commits that reference this issue on May 4, 2025

    Add covariant return types to VectorStore.GetCollection() implementat…

    d60fc90

    Add covariant return types to VectorStore.GetCollection() implementat…

    fe6f603

    Add covariant return types to VectorStore.GetCollection() implementat…

    955f05f
  11. Adam Sitnik (adamsitnik)
    added a commit that references this issue on May 5, 2025

    .Net: Add covariant return types to VectorStore.GetCollection() imple…

    280d98b

  12. adamsitnik commented on May 5, 2025

    @adamsitnik
    Adam Sitnik (adamsitnik)
    on May 5, 2025
    Member

    Fixed with #11883

  13. Adam Sitnik (adamsitnik)
    closed this as completedon May 5, 2025
  14. Shay Rojansky (roji)
    moved this from Sprint: In Review to Sprint: Done in Semantic Kernelon May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

.NETIssue or Pull requests regarding .NET codeBuildFeatures planned for next Build conferencemsft.ext.vectordataRelated to Microsoft.Extensions.VectorData

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions