Skip to content

Don't wrap every exception thrown by the connector with VectorStoreOperationException #11512

Closed

Description

We need to be catching specific exceptions and make sure we don't wrap with VectorStoreOperationException any of the following:

  • ArgumentException
  • NotSupportedException
  • TaskCanceledException

cc Shay Rojansky (@roji) westey (@westey-m)

Activity

  1. roji commented on Apr 15, 2025

    @roji
    Member

    While doing this, also ensure that we're indeed wrapping the relevant connector-specific exceptions everywhere, as discussed in #10883.

  2. moved this from Backlog: Planned to Sprint: Planned in Semantic Kernelon Apr 15, 2025
  3. moved this from Sprint: Planned to Sprint: In Review in Semantic Kernelon Apr 23, 2025
  4. moved this from Sprint: In Review to Sprint: Planned in Semantic Kernelon Apr 23, 2025
  5. moved this from Sprint: Planned to Sprint: In Progress in Semantic Kernelon Apr 23, 2025
  6. stephentoub commented on May 1, 2025

    @stephentoub
    Member

    TaskCanceledException

    TaskCanceledException is a mistake I regret.

    It derives from OperationCanceledException, which is the one everyone should pay attention to. If TaskCanceledException is being referenced anywhere, it's likely a bug to be fixed, replaced by OCE.

    So, for the purposes of this issue, OCE shouldn't be wrapped, either.

  7. moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernelon May 2, 2025
  8. moved this from Sprint: In Review to Sprint: Done in Semantic Kernelon May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BuildFeatures planned for next Build conferencemsft.ext.vectordataRelated to Microsoft.Extensions.VectorData

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions