Skip to content

Java: Properly resolve issues in java/spotbugs-exclude.xml #1113

Closed

Description

Describe the bug
The bug patterns being excluded in java/spotbugs-exlude.xml should be addressed in the code.

To Reproduce
Steps to reproduce the behavior:

  1. checkout the experimental-java branch
  2. cd java
  3. ./mvnw clean verify -Pbug-check

Expected behavior
There should not be a spotbugs-exclude.xml. We should not get any spotbugs errors when compiling with -Pbug-check.
NOTE: This isn't entirely true. There may be issues that we just cannot resolve, or we may know better than spotbugs.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • IDE: [e.g. Visual Studio, VS Code]
  • NuGet Package Version [e.g. 0.1.0]

Additional context
Add any other context about the problem here.

Activity

  1. added
    sk team issueA tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
    on Aug 2, 2023
  2. changed the title [-]Properly resolve issues in java/spotbugs-exclude.xml[/-] [+]Java: Properly resolve issues in java/spotbugs-exclude.xml[/+] on Aug 2, 2023
  3. d3r3kk commented on Aug 29, 2023

    @d3r3kk
    Contributor

    See #1604

  4. moved this from Backlog - Code Style to No status in Java Semantic Kernelon Aug 29, 2023
  5. d3r3kk commented on Feb 8, 2024

    @d3r3kk
    Contributor

    Closed. PR #4800

  6. moved this from Sprint: Planned to Sprint: Done in Semantic Kernelon Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    javaIssue or PR regarding Java codesk team issueA tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions