.Net: Behavior of collection deletion #10882

Activity

1. Mark Wallace (markwallace-microsoft)

   added

   .NETIssue or Pull requests regarding .NET codeIssue or Pull requests regarding .NET code

   msft.ext.vectordataRelated to Microsoft.Extensions.VectorDataRelated to Microsoft.Extensions.VectorData

   on Mar 10, 2025
2. github-actions

   changed the title [-]Behavior of collection deletion[/-] [+].Net: Behavior of collection deletion[/+] on Mar 10, 2025
3. Mark Wallace (markwallace-microsoft)

   assigned

   westey (westey-m)

   on Mar 10, 2025
4. Mark Wallace (markwallace-microsoft)

   added

   triage

   on Mar 10, 2025
5. Sophia Lagerkrans-Pandey (sophialagerkranspandey)

   removed

   triage

   on Mar 10, 2025
6. roji commented on Mar 11, 2025

   

   Shay Rojansky (roji)

   on Mar 11, 2025

   Member

   More actions

   /cc Adam Sitnik (@adamsitnik) this is exactly the kind of thing we should be covering in the specification/conformance tests.
7. Shay Rojansky (roji)

   added

   BuildFeatures planned for next Build conferenceFeatures planned for next Build conference

   on Mar 11, 2025
8. westey-m commented on Mar 11, 2025

   

   westey (westey-m)

   on Mar 11, 2025

   Contributor

   More actions

   I think we should standardize on not throwing if it already does not exist. After all, the desired state has already been reached.
9. Mark Wallace (markwallace-microsoft)

   assigned

   Adam Sitnik (adamsitnik)

   on Mar 11, 2025
10. adamsitnik commented on Mar 11, 2025

    

    Adam Sitnik (adamsitnik)

    on Mar 11, 2025

    Member

    More actions

    I've hit that yesterday, when I decided to write a set of conformance tests when providing test coverage for the Pinecone connector.

    https://github.com/adamsitnik/semantic-kernel/blob/9911ee546273b64eb722e86e65e29d6383eea2bd/dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/CRUD/CollectionConformanceTests.cs#L14-L22

    I've already fixed Redis and included that in #10788. I am going to make sure all the connector behave the same.

    westey (@westey-m) Shay Rojansky (@roji) to be 100% sure:

    • deleting non existing collection should not throw and the same goes for records (both DeleteAsync and DeleteBatchAsync)
    • CreateCollectionIfNotExistsAsync should not throw when the collection exists, even if there is a TOCTOU issue (we check if it does not exist, if so then we call a method that fails because somebody has created it in a meantime)
    • CreateCollectionAsync should throw VectorStoreOperationException when it already exists
11. westey-m commented on Mar 11, 2025

    

    westey (westey-m)

    on Mar 11, 2025

    Contributor

    More actions

    westey (@westey-m) Shay Rojansky (@roji) to be 100% sure:

    Adam Sitnik (@adamsitnik), yes, those behaviors all make sense to me. Thanks for helping to unify these.
    We can update the interface remarks for these methods and the specification document as well to indicate what the behavior will/should be.

    👍React with 👍1Reacted by Adam Sitnik
12. dluc commented on Mar 13, 2025

    

    Devis Lucato (dluc)

    on Mar 13, 2025

    Contributor

    More actions

    InMemoryVectorStoreRecordCollection.CreateCollectionAsync does not throw if a collection already exists

    semantic-kernel/dotnet/src/Connectors/Connectors.Memory.InMemory/InMemoryVectorStoreRecordCollection.cs

    Line 114 in 5e90a43

    public Task CreateCollectionAsync(CancellationToken cancellationToken = default)
13. dluc commented on Mar 13, 2025

    

    Devis Lucato (dluc)

    on Mar 13, 2025

    Contributor

    More actions

    westey (@westey-m) FYI with Qdrant, when a collection doesn't exist, collection deletion fails with an exception:

    Qdrant.Client.QdrantException: Collection 'test123' could not be deleted
    at Qdrant.Client.QdrantClient.DeleteCollectionAsync(String collectionName, Nullable1 timeout, CancellationToken cancellationToken) at Microsoft.SemanticKernel.Connectors.Qdrant.QdrantVectorStoreRecordCollection1.RunOperationAsync(String operationName, Func`1 operation)
14. github-merge-queue

    added 2 commits that reference this issue on Mar 13, 2025

    .Net MEVD: More Conformance tests (#10944)

    ...

    1823554

    .Net MEVD: Unify collection deletion and creation (#10958)

    ...

    a01a31b
15. Adam Sitnik (adamsitnik)

    closed this as completedin #10958on Mar 18, 2025
16. jcruzmot-te

    added 2 commits that reference this issue on Sep 15, 2025

    .Net MEVD: More Conformance tests (microsoft#10944)

    ...

    d14b1d5

    .Net MEVD: Unify collection deletion and creation (microsoft#10958)

    ...

    a92a734