Bug: Adding Ollama completion to the kernel still requires the ollama client

After #10321 was fixed I noticed that when I use the following code to add the Ollama chat completion, I expected to be able to omit the API client, but I can't.

var builder = WebApplication.CreateBuilder(args);

builder.AddOllamaApiClient("languageModel");
builder.Services.AddKernel().AddOllamaChatCompletion();

The code in the OllamaKernelBuilder requires the Ollama client still. It should be made optional.

semantic-kernel/dotnet/src/Connectors/Connectors.Ollama/Extensions/OllamaKernelBuilderExtensions.cs

Lines 149 to 159 in d015742

    
           public static IKernelBuilder AddOllamaChatCompletion( 
        
               this IKernelBuilder builder, 
        
               OllamaApiClient ollamaClient, 
        
               string? serviceId = null) 
        
           { 
        
               Verify.NotNull(builder); 
        
               builder.Services.AddOllamaChatCompletion(ollamaClient, serviceId); 
        
               return builder; 
        
           }

This issue was resolved here:

.Net: Add missing Ollama Connector Aspire Friendly Extensions #10775

Navigation Menu

Repository navigation

Bug: Adding Ollama completion to the kernel still requires the ollama client #10346

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	public static IKernelBuilder AddOllamaChatCompletion(
	this IKernelBuilder builder,
	OllamaApiClient ollamaClient,
	string? serviceId = null)
	{
	Verify.NotNull(builder);

	builder.Services.AddOllamaChatCompletion(ollamaClient, serviceId);

	return builder;
	}

Bug: Adding Ollama completion to the kernel still requires the ollama client #10346

Description

Activity

rogerbarreto commented on Mar 30, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions