Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/semantic-kernel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: java-0.2.8-alpha
Choose a base ref
...
head repository: microsoft/semantic-kernel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: java-0.2.9-alpha
Choose a head ref
  • 14 commits
  • 163 files changed
  • 10 contributors

Commits on Aug 11, 2023

  1. Java: Prepare java dev iteration (#2427)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    joe-braley and web-flow authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    0021b00 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. SKException consistency with docs/decisions/0004-error-handling.md (#…

    …2428)
    
    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    Where it makes sense, align Java with
    https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0004-error-handling.md
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    For the most part, Java is in compliance with the decision record. This
    PR tries to make SKException and its inheritors consistent with each
    other in that each exception has a ErrorCodes enum and an ErrorCodes
    member with a getter, that the enums use upper case with underscore, and
    that the formatting of the error message is consistent. This also tries
    to address "Unnecessary and verbose exceptions", but there was not much
    to be gained there.
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [x] The code builds clean without any errors or warnings
    - [x] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [x] All unit tests pass, and I have added new tests where possible
    - [x] I didn't break anyone 😄
    dsgrieve authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    756236f View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Java: Fix SQLite Memory Connector error when opening existing SK data…

    …base (#2517)
    
    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    Quick fix for #2499
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    Adding `IF NOT EXISTS` to the index creation.
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    
    ---------
    
    Co-authored-by: Luigi Montoya <[email protected]>
    Co-authored-by: joe-braley <[email protected]>
    Co-authored-by: Luigi96 <[email protected]>
    Co-authored-by: Mark Wallace <[email protected]>
    Co-authored-by: John Oliver <[email protected]>
    Co-authored-by: David Grieve <[email protected]>
    7 people authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    5d0d25e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Java: Fixes searchAsync does not limit the number of results (#2599)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    Fixes #2572
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    As per the ACS documentation/sourcode setTop() is the right method to
    control the return of number of search results.
    
    
    https://github.com/Azure/azure-sdk-for-java/blob/fa886839e05fa40fbd2b10100434af0e2a809059/sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/SearchOptions.java#L206
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [x] The code builds clean without any errors or warnings
    - [x] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [x] All unit tests pass, and I have added new tests where possible
    - [x] I didn't break anyone 😄
    kshitijcode authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e245eba View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Java: remove default NullMemory from DefaultSKContext builder (#2605)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    Bug #2183 
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    DefaultSKContext.Builder should not set a default for
    SemanticTextMemory.
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [X] The code builds clean without any errors or warnings
    - [X] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [X] All unit tests pass, and I have added new tests where possible
    - [X] I didn't break anyone 😄
    dsgrieve authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    74b18b9 View commit details
    Browse the repository at this point in the history
  2. Java: Builder naming consistency (#2575)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    Issue #2437 and issue #2346
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    - Changed setXyz methods to withXyz
    - Changed SKBuilders methods to match the builder return type
    - Organized BuilderSingleton to make it easier to maintain, IMHO
    - Consistency between Buildable's
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [x] The code builds clean without any errors or warnings
    - [x] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [x] All unit tests pass, and I have added new tests where possible
    - [x] I didn't break anyone 😄
    dsgrieve authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    beeed7b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Java: Add JDBC and Postgres connectors (#2489)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    Adding JDBC connector from SQLite and Postgres connector overriding
    what's necessary.
    
    Also adding new integration tests for the JDBC and Postgres memory
    connectors under
    `api-test/integration-tests/src/test/java/com/microsoft/semantickernel/connectors`.
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    
    ---------
    
    Co-authored-by: Luigi Montoya <[email protected]>
    Co-authored-by: joe-braley <[email protected]>
    Co-authored-by: Luigi96 <[email protected]>
    Co-authored-by: Mark Wallace <[email protected]>
    Co-authored-by: John Oliver <[email protected]>
    Co-authored-by: David Grieve <[email protected]>
    7 people authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    7a9268d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Java: Add stepwise planner (#2753)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    johnoliver authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7e755c6 View commit details
    Browse the repository at this point in the history
  2. Java: 2514 java minrelevancescore on memory api should be float (#2633)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    Fixes #2514 
    
    ### Description
    Change relevance/minRelevance in API from double to float
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [X] The code builds clean without any errors or warnings
    - [X] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [X] All unit tests pass, and I have added new tests where possible
    - [X] I didn't break anyone 😄
    dsgrieve authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b8df05a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Java - Fix several small bugs (#2791)

    - Use resource loading util method
    - Apply formatting
    - Fix sql connector generating embedding even if db entry already exits
    - Fixes settings not being loaded from environment variables correctly
    johnoliver authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bfe0d95 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Java: Fix memory not updating if the record already exists (#2890)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    johnoliver authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bb0d256 View commit details
    Browse the repository at this point in the history
  2. Java: 2636 net java azurecognitivesearchmemory should implement memor…

    …ystore (#2861)
    
    ### Motivation and Context
    Fixes issue #2636 
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    dsgrieve authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0ede0eb View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Java: Resolve postgresql version (#2928)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    
    Co-authored-by: joe-braley <[email protected]>
    joe-braley and joebraley authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3d9fe91 View commit details
    Browse the repository at this point in the history
  2. Java: [maven-release-plugin] prepare release java-0.2.9-alpha (#2929)

    ### Motivation and Context
    
    <!-- Thank you for your contribution to the semantic-kernel repo!
    Please help reviewers and future users, providing the following
    information:
      1. Why is this change required?
      2. What problem does it solve?
      3. What scenario does it contribute to?
      4. If it fixes an open issue, please link to the issue here.
    -->
    
    ### Description
    
    <!-- Describe your changes, the overall approach, the underlying design.
    These notes will help understanding how your code works. Thanks! -->
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [ ] The code builds clean without any errors or warnings
    - [ ] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [ ] All unit tests pass, and I have added new tests where possible
    - [ ] I didn't break anyone 😄
    
    Co-authored-by: GitHub <[email protected]>
    joe-braley and web-flow authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    95a2ff9 View commit details
    Browse the repository at this point in the history
Loading