Repository navigation
Commit f37f308
authored
Python: Fix Qdrant vector search on qdrant-client 1.16+ (#14562)
### Motivation and Context
Fixes #14561
Qdrant vector search fails on qdrant-client 1.16+ because
`AsyncQdrantClient.search` was removed. Separately, a single comparison
filter such as `lambda x: x.temperature > 1` fails in both vector and
hybrid search. Thanks to the reporter for the detailed write-up and
repro.
### Description
Root cause: `_inner_search` called the removed `search` method, and only
wrapped a list of filters in `Filter(must=...)`, so a lone
`FieldCondition` reached Qdrant unwrapped.
- Vector search now uses `query_points(query=vector, using=<vector name
or None>)` and reads `.points`, like hybrid search already does.
- A filter that is not already a `Filter` is wrapped as
`Filter(must=[...])`.
- The extra's lower bound goes from `~= 1.9` to `~= 1.10`
(`query_points` was added in 1.10). The matching specifier line in
`uv.lock` is edited by hand.
Tests: `test_qdrant.py` mocks now target `query_points`. A new
`test_qdrant_local.py` uses the in-process `:memory:` client for vector
search, vector search with a single filter, and hybrid search with a
single filter. These fail without the fix and pass with it.
Verified on Linux (CPU only, Python 3.10): the Qdrant and
`tests/unit/data` unit tests pass on qdrant-client 1.10.1, 1.12.1 and
1.19.1. `ruff check` and `ruff format --check` are clean.
Not verified: a real Qdrant server, qdrant-client 1.15/1.16
specifically, the full unit suite, mypy, and a regenerated `uv.lock`.
AI use: this change was prepared by an automated AI agent (Claude).
### Contribution Checklist
- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
---------
Co-authored-by: guptaishaan <[email protected]>1 parent 2774526 commit f37f308
5 files changed
Lines changed: 84 additions & 15 deletions
File tree
- python
- semantic_kernel/connectors
- tests/unit/connectors/memory
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
| 139 | + | |
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
277 | | - | |
278 | | - | |
279 | 277 | | |
280 | 278 | | |
281 | 279 | | |
| |||
287 | 285 | | |
288 | 286 | | |
289 | 287 | | |
290 | | - | |
291 | 288 | | |
292 | | - | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
293 | 294 | | |
294 | | - | |
| 295 | + | |
295 | 296 | | |
296 | | - | |
| 297 | + | |
| 298 | + | |
297 | 299 | | |
298 | 300 | | |
299 | 301 | | |
300 | 302 | | |
301 | 303 | | |
302 | 304 | | |
| 305 | + | |
303 | 306 | | |
304 | 307 | | |
305 | 308 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
288 | | - | |
| 288 | + | |
| 289 | + | |
289 | 290 | | |
290 | 291 | | |
291 | 292 | | |
| |||
307 | 308 | | |
308 | 309 | | |
309 | 310 | | |
310 | | - | |
| 311 | + | |
| 312 | + | |
311 | 313 | | |
312 | 314 | | |
313 | 315 | | |
| |||
328 | 330 | | |
329 | 331 | | |
330 | 332 | | |
331 | | - | |
332 | | - | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
333 | 336 | | |
334 | 337 | | |
335 | 338 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments