Skip to content

Commit c3c89ea

Browse files
authored
Fix import_semantic_skill_from_directory (#236)
### Motivation and Context This PR fixes #235 and adds a test for the functionality. This is ahead of the planning skill. ### Description 1. Fix to fix the typo in the `from_dict()` method in `prompt_template_config.py` 2. Add assignment back to skill config so results from JSON aren't discarded in `import_semantic_skill_from_directory.py` 3. Add tests
1 parent 6d7812b commit c3c89ea

5 files changed

Lines changed: 56 additions & 10 deletions

File tree

‎python/semantic_kernel/kernel_extensions/import_semantic_skill_from_directory.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def import_semantic_skill_from_directory(
4242
config = PromptTemplateConfig()
4343
config_path = os.path.join(directory, CONFIG_FILE)
4444
with open(config_path, "r") as config_file:
45-
config.from_json(config_file.read())
45+
config = config.from_json(config_file.read())
4646

4747
# Load Prompt Template
4848
with open(prompt_path, "r") as prompt_file:

‎python/semantic_kernel/semantic_functions/prompt_template_config.py‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,19 @@ class InputConfig:
4040
def from_dict(data: dict) -> "PromptTemplateConfig":
4141
config = PromptTemplateConfig()
4242
config.schema = data.get("schema")
43-
config.type = data.get("type)")
43+
config.type = data.get("type")
4444
config.description = data.get("description")
4545

4646
# Some skills may not have all completion parameters defined
4747
config.completion = PromptTemplateConfig.CompletionConfig()
48-
completition_dict = data["completion"]
49-
config.completion.temperature = completition_dict.get("temperature")
50-
config.completion.top_p = completition_dict.get("top_p")
51-
config.completion.presence_penalty = completition_dict.get("presence_penalty")
52-
config.completion.frequency_penalty = completition_dict.get("frequency_penalty")
53-
config.completion.max_tokens = completition_dict.get("max_tokens")
54-
config.completion.stop_sequences = completition_dict.get("stop_sequences")
55-
config.default_backends = data.get("default_backends")
48+
completion_dict = data["completion"]
49+
config.completion.temperature = completion_dict.get("temperature")
50+
config.completion.top_p = completion_dict.get("top_p")
51+
config.completion.presence_penalty = completion_dict.get("presence_penalty")
52+
config.completion.frequency_penalty = completion_dict.get("frequency_penalty")
53+
config.completion.max_tokens = completion_dict.get("max_tokens")
54+
config.completion.stop_sequences = completion_dict.get("stop_sequences")
55+
config.default_backends = data.get("default_backends", [])
5656

5757
# Some skills may not have input parameters defined
5858
config.input = PromptTemplateConfig.InputConfig()

‎python/tests/test_config.py‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# Copyright (c) Microsoft. All rights reserved.
2+
3+
import os
4+
import pytest
5+
import semantic_kernel as sk
6+
import semantic_kernel.kernel_extensions.import_semantic_skill_from_directory as importer
7+
8+
9+
def test_can_be_imported():
10+
# create a kernel
11+
kernel = sk.create_kernel()
12+
api_key = "test-api-key"
13+
org_id = "test-org-id"
14+
kernel.config.add_openai_completion_backend("test-completion-backend", api_key, org_id)
15+
16+
# import skills
17+
skills_directory = os.path.join(os.path.dirname(__file__), "test_skills")
18+
# path to skills directory
19+
skill_config_dict = importer.import_semantic_skill_from_directory(kernel, skills_directory, "TestSkill")
20+
21+
assert skill_config_dict is not None
22+
assert len(skill_config_dict) == 1
23+
assert "TestFunction" in skill_config_dict
24+
skill_config = skill_config_dict["TestFunction"]
25+
assert skill_config.name == "TestFunction"
26+
assert skill_config.description == "Test Description"
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"schema": 1,
3+
"type": "completion",
4+
"description": "Test Description",
5+
"completion": {
6+
"max_tokens": 123,
7+
"temperature": 0.0,
8+
"top_p": 1.0,
9+
"presence_penalty": 0.0,
10+
"frequency_penalty": 2.0
11+
},
12+
"default_backends": [
13+
"test-completion-backend"
14+
]
15+
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{{$input}}
2+
3+
==
4+
Test prompt.
5+
==

0 commit comments

Comments
 (0)