Repository navigation
Commit 7e68276
fix(ci): select integration test events explicitly (#14603)
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
1. Why is this change required?
2. What problem does it solve?
3. What scenario does it contribute to?
4. If it fixes an open issue, please link to the issue here.
-->
Select integration-test jobs using pull-request repository identity
while retaining build and unit-test checks for all pull requests and the
merge queue.
### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
- Skip integration jobs for fork pull requests and Dependabot-triggered
pull requests, while allowing other same-repository pull requests, merge
groups, and manual runs on repository branches. The Dependabot exclusion
applies only to pull-request events.
- Preserve the existing scheduled/manual split for the full Python
integration suite.
- Separate .NET integration tests from build and unit-test jobs, and
include the separate job in the final result check.
- Keep Python integration settings on test steps and integration setup
permissions on the jobs that use them.
Validation from the isolated worktree:
- Temporary session-only checks using the Actions expression evaluator:
the initial event-policy update passed all 19 cases after 9 intended
assertion failures. For the Dependabot refinement, `node
'<session-files>\workflow-policy-check\check.mjs'
'D:\github\semantic-kernel-integration-event-selection'` produced 3
intended Dependabot-PR assertion failures and 20 passes before the fix;
afterward, all 23 cases passed. Coverage includes same-repository human
PRs, Dependabot PRs, fork PRs, unavailable PR head repositories, merge
groups and manual runs with a Dependabot actor, manual topic-branch
runs, and the Python scheduled/manual split. No new CI unit tests or
dependencies are retained in this PR.
- `actionlint -shellcheck= -pyflakes= -ignore 'constant expression
"false" in condition' .github\workflows\dotnet-build-and-test.yml
.github\workflows\dotnet-integration-tests.yml
.github\workflows\python-integration-tests.yml`: passed. The exclusion
covers three pre-existing constant-false conditions in disabled Python
steps, confirmed against the base revision.
- `git diff --check`: passed.
Live integration tests and repository-wide .NET/Python builds were not
run locally. The initial PR revision passed all applicable GitHub
checks, including the three .NET build-and-test jobs; the updated
revision requires a fresh CI run.
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
---------
Co-authored-by: Copilot <[email protected]>
Copilot-Session: 7d5f1773-4610-4dc8-8e7a-6cd710cfda0e1 parent 5b4a326 commit 7e68276
3 files changed
Lines changed: 129 additions & 98 deletions
File tree
- .github/workflows
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
63 | | - | |
64 | | - | |
65 | 62 | | |
66 | 63 | | |
67 | 64 | | |
68 | 65 | | |
69 | 66 | | |
70 | | - | |
71 | 67 | | |
72 | 68 | | |
73 | 69 | | |
| |||
124 | 120 | | |
125 | 121 | | |
126 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
127 | 159 | | |
128 | | - | |
129 | 160 | | |
130 | 161 | | |
131 | 162 | | |
| |||
134 | 165 | | |
135 | 166 | | |
136 | 167 | | |
137 | | - | |
138 | 168 | | |
139 | 169 | | |
140 | 170 | | |
141 | | - | |
| 171 | + | |
142 | 172 | | |
143 | 173 | | |
144 | 174 | | |
| |||
182 | 212 | | |
183 | 213 | | |
184 | 214 | | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | 215 | | |
204 | 216 | | |
205 | 217 | | |
206 | 218 | | |
207 | | - | |
| 219 | + | |
208 | 220 | | |
209 | 221 | | |
210 | 222 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | | - | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
39 | | - | |
40 | 38 | | |
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
44 | | - | |
45 | 42 | | |
46 | 43 | | |
47 | 44 | | |
| |||
64 | 61 | | |
65 | 62 | | |
66 | 63 | | |
67 | | - | |
| 64 | + | |
0 commit comments