Repository navigation
Commit 6e2d314
authored
Change visibility modifiers on MemoryRecord and associated collection classes (#250)
### Motivation and Context
`MemoryRecord`, along with several useful classes in the
`SemanticKernel.Memory.Collections` namespace currently have an internal
visibility modifier.
This prevents 3rd party libraries from reusing code when creating
implementations of `IEmbeddingWithMetadata<float>`, which is needed in
implementations of `IMemoryStore<TEmbedding>`
Two implementations are currently blocked on this:
* Skills.Memory.Sqlite
* Skills.Memory.CosmosDB
As both of these backing stores are not vector DB stores, they implement
cosine similarity comparisons locally, which is performed using
`TopNCollection` and its dependencies, all of which are currently
internal.
Related community feedback item here:
#202
### Description
Change the following classes from internal to public:
* MemoryRecord
* MinHeap
* Score
* ScoredValue
* TopNCollection1 parent bcd740b commit 6e2d314
5 files changed
Lines changed: 7 additions & 5 deletions
File tree
- dotnet/src/SemanticKernel/Memory
- Collections
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
| 96 | + | |
95 | 97 | | |
96 | 98 | | |
97 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
0 commit comments