Skip to content

Commit 27e1831

Browse files
joowon-dm-snudluc
authored andcommitted
Fix for running samples/notebooks/python/6-memory-and-embeddings.ipynb (#166)
### Motivation and Context Please help reviewers and future users, providing the following information: 1. Why is this change required? `SemanticTextMemory.save_reference_async` do nothing for its storage. 2. What problem does it solve? `save_reference_async` will work appropriately 3. What scenario does it contribute to? embeddings 4. If it fixes an open issue, please link to the issue here. #165 ### Description I add missing codes with references of `SemanticTextMemory.save_information_async` and C# version of `SemanticTextMemory.save_reference_async`
1 parent 5ea0242 commit 27e1831

2 files changed

Lines changed: 12 additions & 8 deletions

File tree

‎python/semantic_kernel/memory/semantic_text_memory.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,12 @@ async def save_reference_async(
4242
description: Optional[str] = None,
4343
) -> None:
4444
embedding = await self._embeddings_generator.generate_embeddings_async([text])
45-
MemoryRecord.reference_record(
45+
data = MemoryRecord.reference_record(
4646
external_id, external_source_name, description, embedding
4747
)
4848

49+
await self._storage.put_value_async(collection, external_id, data)
50+
4951
async def get_async(
5052
self,
5153
collection: str,

‎samples/notebooks/python/6-memory-and-embeddings.ipynb‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,21 +64,23 @@
6464
" sk.kernel_builder()\n",
6565
" .configure(\n",
6666
" lambda c: c.add_azure_openai_completion_backend(\n",
67-
" \"davinci-002\", \"text-davinci-002\", endpoint, api_key\n",
67+
" \"davinci-002\", \"text-davinci-002\", endpoint, api_key, overwrite=True\n",
6868
" ) if (useAzureOpenAI) else c.add_openai_completion_backend(\n",
69-
" \"davinci-002\", \"text-davinci-002\", api_key, org_id\n",
69+
" \"davinci-002\", \"text-davinci-002\", api_key, org_id, overwrite=True\n",
7070
" )\n",
7171
" )\n",
7272
" .configure(\n",
7373
" lambda c: c.add_azure_openai_embeddings_backend(\n",
74-
" \"ada-002\", \"text-embedding-ada-002\", endpoint, api_key\n",
74+
" \"ada-002\", \"text-embedding-ada-002\", endpoint, api_key, overwrite=True\n",
7575
" ) if (useAzureOpenAI) else c.add_open_ai_embeddings_backend(\n",
76-
" \"ada-002\", \"text-embedding-ada-002\", api_key, org_id\n",
76+
" \"ada-002\", \"text-embedding-ada-002\", api_key, org_id, overwrite=True\n",
7777
" )\n",
7878
" )\n",
7979
" .with_memory_storage(sk.memory.VolatileMemoryStore())\n",
8080
" .build()\n",
8181
" )\n",
82+
"\n",
83+
" kernel.import_skill(TextMemorySkill())\n",
8284
" \n",
8385
" return kernel"
8486
]
@@ -394,9 +396,9 @@
394396
"i = 0\n",
395397
"for memory in memories:\n",
396398
" print(\"Result {++i}:\")\n",
397-
" print(\" URL: : \" + memory.Id)\n",
398-
" print(\" Title : \" + memory.Description)\n",
399-
" print(\" Relevance: \" + memory.Relevance)\n",
399+
" print(\" URL: : \" + memory.id)\n",
400+
" print(\" Title : \" + memory.description)\n",
401+
" print(\" Relevance: \" + str(memory.relevance))\n",
400402
" print()"
401403
]
402404
},

0 commit comments

Comments
 (0)