Skip to content

Commit 20705e0

Browse files
Copilotrogerbarreto
andcommitted
Address PR feedback: Remove Obsolete attribute from ThinkingBudget, remove pragma warnings, rename sample file
Co-authored-by: rogerbarreto <[email protected]>
1 parent 5b43f22 commit 20705e0

7 files changed

Lines changed: 1 addition & 17 deletions

File tree

dotnet/samples/Concepts/ChatCompletion/Google_GeminiChatCompletionWithThinkingBudget.cs renamed to dotnet/samples/Concepts/ChatCompletion/Google_GeminiChatCompletionWithThinking.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace ChatCompletion;
1414
/// See: https://developers.googleblog.com/en/start-building-with-gemini-25-flash/#:~:text=thinking%20budgets
1515
/// </para>
1616
/// </summary>
17-
public sealed class Google_GeminiChatCompletionWithThinkingBudget(ITestOutputHelper output) : BaseTest(output)
17+
public sealed class Google_GeminiChatCompletionWithThinking(ITestOutputHelper output) : BaseTest(output)
1818
{
1919
[Fact]
2020
public async Task GoogleAIChatCompletionUsingThinkingBudget()
@@ -32,13 +32,11 @@ public async Task GoogleAIChatCompletionUsingThinkingBudget()
3232

3333
var chatHistory = new ChatHistory("You are an expert in the tool shop.");
3434
var chat = kernel.GetRequiredService<IChatCompletionService>();
35-
#pragma warning disable CS0618 // Type or member is obsolete - ThinkingBudget is deprecated but still needed for Gemini 2.5 models
3635
var executionSettings = new GeminiPromptExecutionSettings
3736
{
3837
// This parameter gives the model how much tokens it can use during the thinking process.
3938
ThinkingConfig = new() { ThinkingBudget = 2000 }
4039
};
41-
#pragma warning restore CS0618 // Type or member is obsolete
4240

4341
// First user message
4442
chatHistory.AddUserMessage("Hi, I'm looking for new power tools, any suggestion?");

‎dotnet/src/Connectors/Connectors.Google.UnitTests/Core/Gemini/GeminiRequestTests.cs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -708,21 +708,17 @@ public void FromPromptAndExecutionSettingsWithThinkingConfigReturnsInGenerationC
708708
{
709709
// Arrange
710710
var prompt = "prompt-example";
711-
#pragma warning disable CS0618 // Type or member is obsolete - testing deprecated ThinkingBudget property
712711
var executionSettings = new GeminiPromptExecutionSettings
713712
{
714713
ModelId = "gemini-2.5-flash-preview-04-17",
715714
ThinkingConfig = new GeminiThinkingConfig { ThinkingBudget = 1024 }
716715
};
717-
#pragma warning restore CS0618 // Type or member is obsolete
718716

719717
// Act
720718
var request = GeminiRequest.FromPromptAndExecutionSettings(prompt, executionSettings);
721719

722720
// Assert
723-
#pragma warning disable CS0618 // Type or member is obsolete - testing deprecated ThinkingBudget property
724721
Assert.Equal(executionSettings.ThinkingConfig.ThinkingBudget, request.Configuration?.ThinkingConfig?.ThinkingBudget);
725-
#pragma warning restore CS0618 // Type or member is obsolete
726722
}
727723

728724
[Fact]

‎dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,7 @@ public void ItCreatesGeminiExecutionSettingsFromJsonSnakeCase()
133133
settings.Category.Equals(category) &&
134134
settings.Threshold.Equals(threshold));
135135

136-
#pragma warning disable CS0618 // Type or member is obsolete - testing deprecated ThinkingBudget property
137136
Assert.Equal(1000, executionSettings.ThinkingConfig?.ThinkingBudget);
138-
#pragma warning restore CS0618 // Type or member is obsolete
139137
}
140138

141139
[Fact]

‎dotnet/src/Connectors/Connectors.Google.UnitTests/Services/GoogleAIGeminiChatCompletionServiceTests.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,14 +119,12 @@ public async Task RequestBodyIncludesThinkingConfigWhenSetAsync(int? thinkingBud
119119
string model = "gemini-2.5-pro";
120120
var sut = new GoogleAIGeminiChatCompletionService(model, "key", httpClient: this._httpClient);
121121

122-
#pragma warning disable CS0618 // Type or member is obsolete - testing deprecated ThinkingBudget property
123122
var executionSettings = new GeminiPromptExecutionSettings
124123
{
125124
ThinkingConfig = thinkingBudget.HasValue
126125
? new GeminiThinkingConfig { ThinkingBudget = thinkingBudget.Value }
127126
: null
128127
};
129-
#pragma warning restore CS0618 // Type or member is obsolete
130128

131129
// Act
132130
var result = await sut.GetChatMessageContentAsync("my prompt", executionSettings);

‎dotnet/src/Connectors/Connectors.Google.UnitTests/Services/VertexAIGeminiChatCompletionServiceTests.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,12 @@ public async Task RequestBodyIncludesThinkingConfigWhenSetAsync(int? thinkingBud
131131
string model = "gemini-2.5-pro";
132132
var sut = new VertexAIGeminiChatCompletionService(model, () => new ValueTask<string>("key"), "location", "project", httpClient: this._httpClient);
133133

134-
#pragma warning disable CS0618 // Type or member is obsolete - testing deprecated ThinkingBudget property
135134
var executionSettings = new GeminiPromptExecutionSettings
136135
{
137136
ThinkingConfig = thinkingBudget.HasValue
138137
? new GeminiThinkingConfig { ThinkingBudget = thinkingBudget.Value }
139138
: null
140139
};
141-
#pragma warning restore CS0618 // Type or member is obsolete
142140

143141
// Act
144142
var result = await sut.GetChatMessageContentAsync("my prompt", executionSettings);

‎dotnet/src/Connectors/Connectors.Google/Core/Gemini/Models/GeminiRequest.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,13 +498,11 @@ private static void AddAdditionalBodyFields(GeminiPromptExecutionSettings execut
498498
if (executionSettings.ThinkingConfig is not null)
499499
{
500500
request.Configuration ??= new ConfigurationElement();
501-
#pragma warning disable CS0618 // Type or member is obsolete - ThinkingBudget is deprecated but still needs to be sent for backwards compatibility
502501
request.Configuration.ThinkingConfig = new GeminiRequestThinkingConfig
503502
{
504503
ThinkingBudget = executionSettings.ThinkingConfig.ThinkingBudget,
505504
ThinkingLevel = executionSettings.ThinkingConfig.ThinkingLevel
506505
};
507-
#pragma warning restore CS0618 // Type or member is obsolete
508506
}
509507
}
510508

‎dotnet/src/Connectors/Connectors.Google/GeminiThinkingConfig.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// Copyright (c) Microsoft. All rights reserved.
22

3-
using System;
43
using System.Text.Json.Serialization;
54

65
namespace Microsoft.SemanticKernel.Connectors.Google;
@@ -19,7 +18,6 @@ public class GeminiThinkingConfig
1918
/// This parameter is specific to Gemini 2.5 and similar experimental models.
2019
/// If no ThinkingBudget is explicitly set, the API default (likely 0) will be used
2120
/// </remarks>
22-
[Obsolete("ThinkingBudget is deprecated in Gemini 3.0. Use ThinkingLevel instead.")]
2321
[JsonPropertyName("thinking_budget")]
2422
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
2523
public int? ThinkingBudget { get; set; }

0 commit comments

Comments
 (0)