Skip to content

Commit 0dbb29e

Browse files
committed
Increasing linter line length to 120. Fixing linter issues
1 parent 68e260a commit 0dbb29e

37 files changed

Lines changed: 53 additions & 41 deletions

File tree

‎python/.conf/flake8.cfg‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[flake8]
2-
max-line-length = 88
2+
max-line-length = 120
33
extend-ignore = E203

‎python/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,4 @@ The force is proportional to the product of the two masses and inversely proport
9696
## How does this compare to the C# version of Semantic Kernel?
9797

9898
Refer to the [FEATURE_PARITY.md](FEATURE_PARITY.md) doc to see where
99-
things stand in matching the features and functionality of the main SK branch.
99+
things stand in matching the features and functionality of the main SK branch.

‎python/pyproject.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ pytest-asyncio = "^0.21.0"
2525
[tool.isort]
2626
profile = "black"
2727

28+
[tool.ruff]
29+
line-length = 120
30+
2831
[build-system]
2932
requires = ["poetry-core"]
3033
build-backend = "poetry.core.masonry.api"

‎python/semantic_kernel/core_skills/constants.py‎

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Copyright (c) Microsoft. All rights reserved.
22

3-
GET_CONVERSATION_ACTION_ITEMS_DEFINITION = '''You are an action item extractor. You will be given chat history and need to make note of action items mentioned in the chat.
4-
Extract action items from the content if there are any. If there are no action, return nothing. If a single field is missing, use an empty string.
3+
GET_CONVERSATION_ACTION_ITEMS_DEFINITION = '''You are an action item extractor.
4+
You will be given chat history and need to make note of action items mentioned in the chat.
5+
Extract action items from the content if there are any.
6+
If there are no action, return nothing.
7+
If a single field is missing, use an empty string.
58
Return the action items in json.
69
710
Possible statuses for action items are: Open, Closed, In Progress.
@@ -42,7 +45,8 @@
4245
4346
OUTPUT:'''
4447

45-
GET_CONVERSATION_TOPICS_DEFINITION = """Analyze the following extract taken from a conversation transcript and extract key topics.
48+
GET_CONVERSATION_TOPICS_DEFINITION = """
49+
Analyze the following extract taken from a conversation transcript and extract key topics.
4650
- Topics only worth remembering.
4751
- Be brief. Short phrases.
4852
- Can use broken English.
@@ -51,7 +55,9 @@
5155
- NO LONG SENTENCES. SHORT PHRASES.
5256
- Return in JSON
5357
[Input]
54-
My name is Macbeth. I used to be King of Scotland, but I died. My wife's name is Lady Macbeth and we were married for 15 years. We had no children. Our beloved dog Toby McDuff was a famous hunter of rats in the forest.
58+
My name is Macbeth. I used to be King of Scotland, but I died.
59+
My wife's name is Lady Macbeth and we were married for 15 years. We had no children.
60+
Our beloved dog Toby McDuff was a famous hunter of rats in the forest.
5561
My tragic story was immortalized by Shakespeare in a play.
5662
[Output]
5763
{
@@ -76,7 +82,8 @@
7682
7783
END CONTENT TO SUMMARIZE.
7884
79-
Summarize the conversation in 'CONTENT TO SUMMARIZE', identifying main points of discussion and any conclusions that were reached.
85+
Summarize the conversation in 'CONTENT TO SUMMARIZE',
86+
identifying main points of discussion and any conclusions that were reached.
8087
Do not incorporate other general knowledge.
8188
Summary is in plain text, in complete sentences, with no markup or tags.
8289

‎python/semantic_kernel/core_skills/conversation_summary_skill.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
# Copyright (c) Microsoft. All rights reserved.
22

33
from typing import List
4+
45
import core_skills.constants as constants
56
from orchestration.sk_context import SKContext
7+
from skill_definition.sk_function_decorator import sk_function
8+
69
import semantic_kernel as sk
710
from python.semantic_kernel.kernel_base import KernelBase
811
from python.semantic_kernel.orchestration.sk_function_base import SKFunctionBase
9-
from skill_definition.sk_function_decorator import sk_function
1012

1113

1214
class ConversationSummarySkill:

‎python/semantic_kernel/orchestration/sk_function.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Copyright (c) Microsoft. All rights reserved.
22

3+
import asyncio
4+
import threading
35
from enum import Enum
46
from logging import Logger
5-
import threading
67
from typing import Any, Callable, List, Optional, cast
7-
import asyncio
88

99
from semantic_kernel.ai.chat_completion_client_base import ChatCompletionClientBase
1010
from semantic_kernel.ai.chat_request_settings import ChatRequestSettings

‎samples/skills/CalendarSkill/AssistantShowCalendarEvents/config.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
"\n"
1313
]
1414
}
15-
}
15+
}

‎samples/skills/ChatSkill/ChatFilter/config.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
"</scenario>"
1313
]
1414
}
15-
}
15+
}

‎samples/skills/ChatSkill/ChatUser/config.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
"AI:"
1414
]
1515
}
16-
}
16+
}

‎samples/skills/ChatSkill/ChatV2/config.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
"</message>"
1313
]
1414
}
15-
}
15+
}

0 commit comments

Comments
 (0)