Repository navigation
Add notebook dependency completion coverage - #3899
Open
Brun3y (BrUn3y) wants to merge 2 commits into
Open
Brun3y (BrUn3y) wants to merge 2 commits into
Brun3y (BrUn3y) wants to merge 2 commits into
Conversation
Brun3y (BrUn3y)
requested review from
Andrew Casey (amcasey),
Bill Ticehurst (billti) and
Ian Davis (idavis)
as code owners
October 6, 2026 23:06
Author
|
@microsoft-github-policy-service agree |
Author
|
Andrew Casey (@amcasey) could you please review this PR? I've resolved the merge conflict with the latest Validation on the updated branch:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the notebook dependency completion coverage and test-helper changes.
No open issues 🎉
What changed in this PR
Adds language-service test coverage for notebooks connected to Q# projects with package dependencies, addressing #1768.
Changes:
- Verifies dependency exports appear in notebook completions with the expected package-qualified import, and that already imported items do not trigger duplicate imports.
- Extracts an update-handler helper that accepts a custom virtual file system while preserving the existing default helper.
| File | Description |
|---|---|
source/language_service/src/tests.rs |
Adds notebook dependency completion coverage and a reusable custom-file-system test helper. |
Review effort: Balanced
Andrew Casey (amcasey)
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add notebook dependency completion coverage
Description
Adds the missing language-service coverage for completions in notebooks connected to a Q# project with package dependencies.
The new integration test uses a virtual file system containing a project and a local dependency. It verifies that:
Closes #1768.
Validation
cargo fmt --all --checkcargo test -p qslscargo clippy -p qsls --tests -- -D warnings