pandas: fix iloc to accept list #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gramster
reviewed
Apr 19, 2022
| np_ndarray_bool = npt.NDArray[np.bool_] | ||
| np_ndarray_str = npt.NDArray[np.str_] | ||
| IndexType = Union[slice, np_ndarray_int64, Index, List[int], Series[int]] | ||
| MaskType = Union[Series[bool], np_ndarray_bool, Sequence[bool]] |
Member
There was a problem hiding this comment.
This change doesn't make sense to me. A List is a Sequence, and Sequence is preferred when typing args. Where you having issues with the way it was?
Contributor
Author
There was a problem hiding this comment.
Sequence includes Tuple, and we have to differentiate those cases in pandas.
If you do df.iloc[3,4], the argument is a tuple, and returns a scalar. If you do df.iloc[[3,4]], the argument is a list, and returns a DataFrame. Sequence matches both cases. Also, Sequence matches a str, which is painful in other contexts.
Member
There was a problem hiding this comment.
Got it, thanks for clarifying. I think when I created these a lot of the time the docs said things like "list-like" and those I went and made Sequence.
gramster
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
DataFrame.ilocto accept lists, etc. that produce aDataFrame