Multiple fixes related to Timedelta and indexes #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Multiplication of a number and an untyped series keeps it untyped (was Series[Timedelta]) - Multiplicaiton of a series and Series[Timedelta] gives Series[Timedelta] - Series[Timestamp] minus Timedelta or Series[Timedelta] gives Series[Timestamp] - MultiIndex.astype returns MultiIndex - DataFrame.__setitem__ needs to accept IndexSlice as an argument on a single column - Series[Timedelta] plus DatetimeIndex is Series[Timestamp] - to_timedelta returns Series[Timedelta] when passed a Series - DatetimeIndex plus timedeltas is DatetimeIndex
bschnurr
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes that were identified by applying pylance 2022.3.2 to our code:
Series[Timedelta])Series[Timedelta]givesSeries[Timedelta]Series[Timestamp]minusTimedeltaorSeries[Timedelta]givesSeries[Timestamp]MultiIndex.astypereturnsMultiIndexDataFrame.__setitem__needs to acceptIndexSliceas an argument on a single columnSeries[Timedelta]plusDatetimeIndexisSeries[Timestamp]to_timedeltareturnsSeries[Timedelta]when passed aSeriesDatetimeIndexplus timedeltas isDatetimeIndexNote: There are probably other arithmetic things we need to fix as well related to
TimestampandTimedelta