[pandas] Fix pandas Timedelta total_seconds return type #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `total_seconds` method returns a float, rather than an int. This can be tested/confirmed as follows: ```python import pandas as pd ptd = pd.to_timedelta(1234.5678, unit="s") print(ptd.total_seconds()) # 1234.5678 print(type(ptd.total_seconds())) # <class 'float'> print(type(ptd)) # <class 'pandas._libs.tslibs.timedeltas.Timedelta'> ```
gramster
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
total_secondsmethod returns a float, rather than an int. I noticed this problem seeing incorrect typing within VSCode.The correct return type can be tested/confirmed as follows:
And similarly in the types within the pandas repo https://github.com/pandas-dev/pandas/blob/7f97e27241dc520038d8d1b0de114afec3ad24df/pandas/_libs/tslibs/timedeltas.pyi#L50