This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Unpacking typing Tuples and Lists correctly #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Callables.cs
Outdated
Show resolved
Hide resolved
jakebailey
previously approved these changes
Sep 3, 2019
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
LGTM, but I think we said we were going to wait to merge this until the persistence goes in.
… scratch/UnpackingLogicWithTyping
MikhailArkhipov
approved these changes
Sep 6, 2019
… scratch/UnpackingLogicWithTyping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1457
Fixes #1494
Fixes #411
Fixes #1382
Fixes #1293
Also swapped all the PythonInstance constructor calls (when they are not needed) to the
IPythonType.CreateInstance