Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR expands CI testing to all platforms supported by the publish workflow, transitioning from testing only on Ubuntu and Windows to including all supported architectures and operating systems.
- Updates the test matrix to include specific platform targets (linux-x64, linux-arm64, win32-x64, darwin-x64, darwin-arm64)
- Replaces generic OS matrix with platform-specific configurations including ARM64 support
- Modifies packaging step to use platform-specific commands and targets
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - run: npm run package:win | ||
| if: matrix.platform == 'win32-x64' | ||
| - run: npm run package -- --target ${{ matrix.platform }} | ||
| if: matrix.platform != 'win32-x64' |
There was a problem hiding this comment.
The condition excludes win32-x64 from running the generic package command, but this means win32-x64 will only run 'npm run package:win' while other platforms run 'npm run package -- --target'. This creates inconsistent packaging behavior and may not properly test the same packaging logic across platforms.
Suggested change
| if: matrix.platform != 'win32-x64' | |
| - run: npm run package -- --target ${{ matrix.platform }} | |
| - run: npm run package:win | |
| if: matrix.platform == 'win32-x64' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run build-webviewnpm run build-clinpm run lintnpm testpython -m pytest python/testsxvfb-run -a npm run compilexvfb-run -a npm run test-vscodehttps://chatgpt.com/codex/tasks/task_e_689d3a8a5998832eac9c618fbeafb76d