Thanks for pushing the fix.

I think it should be fixed the other way around.

Speaker = Literal["human", "assistant", "system"] should be human, ai, system.

Thanks for pushing the fix.

I think it should be fixed the other way around.

Speaker = Literal["human", "assistant", "system"] should be human, ai, system.

yeah，that's right. I'll make some changes, thanks.

Emmm.. The openai_chat is unrelated to the pydantic here.

For the pydantic, changing Speaker = Literal["human", "assistant", "system"] to Speaker = Literal["human", "ai", "system"] is enough. No other changes required.

Emmm.. The openai_chat is unrelated to the pydantic here.

For the pydantic, changing Speaker = Literal["human", "assistant", "system"] to Speaker = Literal["human", "ai", "system"] is enough. No other changes required.

When 'format = "openai_chat"', only changing Speaker = Literal["human", "assistant", "system"] to Speaker = Literal["human", "ai", "system"] will causing problem. _poml_response_to_openai_chat function needs change.

I don't think the original speaker returned by POML will ever be assistant? The speakers in the input of _poml_response_to_openai_chat must belong to human, ai and system, if I understand correctly.

I don't think the original speaker returned by POML will ever be assistant? The speakers in the input of _poml_response_to_openai_chat must belong to human, ai and system, if I understand correctly.

If that _poml_response_to_openai_chat still needs to change, now this function only support human, assistant and system. No matter what it will eventually be converted into user, assistant, and system.

If it's ok i'll remove assistant finally.

Sorry I mistakenly see "assistant": "assistant" as the change. I apologize for the confusion.

Seems that your change is correct. Please remove ""assistant": "assistant", from speaker_to_role and "assistant" from Speaker.

Sorry I mistakenly see "assistant": "assistant" as the change. I apologize for the confusion.

Seems that your change is correct. Please remove ""assistant": "assistant", from speaker_to_role and "assistant" from Speaker.

Ok, I have already removed it, thanks for review.