Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a nightly build system for the POML project, bumping the version from 0.0.7 to 0.0.8 and adding comprehensive CI/CD workflows for publishing to multiple platforms.
- Adds automated version bumping script supporting nightly and development builds
- Implements multi-platform build and publish workflows for NPM, PyPI, and VSCode extensions
- Enhances version comparison logic to handle nightly/development versions
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/poml/_version.py | Version bump from 0.0.7 to 0.0.8 |
| pyproject.toml | Version bump from 0.0.7 to 0.0.8 |
| packages/poml/version.ts | Version bump from 0.0.7 to 0.0.8 |
| packages/poml/file.tsx | Enhanced version comparison to support nightly builds |
| packages/poml-build/package.json | Version bump from 0.0.7 to 0.0.8 |
| package.json | Version bump from 0.0.7 to 0.0.8 |
| bump-version.js | New script for automated version management |
| .github/workflows/* | New CI/CD workflows for publishing and nightly builds |
| return -1; | ||
| const parseVersion = (version: string) => { | ||
| // Handle nightly versions: "1.2.3-nightly.202508120345" | ||
| const nightlyMatch = version.match(/^(\d+\.\d+\.\d+)-nightly\.(\d+)$/); |
There was a problem hiding this comment.
The regex pattern should include validation for the dev format mentioned in the comment but not handled in the implementation. The comment states support for 'x.y.z.devtimestamp' but only handles nightly format.
| mode = 'python'; | ||
| } else if (timestampOrFlag === '--nodejs-only') { | ||
| mode = 'nodejs'; | ||
| } else if (/^\d{12,14}$/.test(timestampOrFlag)) { |
There was a problem hiding this comment.
The regex pattern allows 12-14 digits but the usage examples show YYYYMMDDHHMM (12 digits) or YYYYMMDDHHMMSS (14 digits). Consider making this more explicit with separate patterns for each format to improve clarity.
| } else if (/^\d{12,14}$/.test(timestampOrFlag)) { | |
| } else if (/^(\d{12}|\d{14})$/.test(timestampOrFlag)) { |
No description provided.