Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds regression tests for the autoAddAssociatedFiles behavior in the POML VS Code extension. The tests verify that associated context and stylesheet files are automatically added to panels when they follow the expected naming convention, and confirm that manual user customization prevents the auto-adding mechanism from overriding user preferences.
- Added comprehensive test coverage for auto-add functionality
- Verified manual user changes take precedence over auto-add behavior
- Included proper test cleanup and isolation
Comments suppressed due to low confidence (3)
packages/poml-vscode/tests/panelAutoAdd.test.ts:12
- [nitpick] The parameter name
_is not descriptive. Consider using a more meaningful name like_listeneror_handlerto clarify this is an unused parameter.
public readonly onDidChangeTopmostLine = (_: any) => {};
packages/poml-vscode/tests/panelAutoAdd.test.ts:24
- [nitpick] The parameter name
_msgcould be more descriptive. Consider using_messageto be more explicit about the unused parameter.
postMessage: (_msg: any) => {},
packages/poml-vscode/tests/panelAutoAdd.test.ts:34
- The variable name
PanelClassis misleading since it's just an alias forPOMLWebviewPanel. Consider using a more descriptive name likePanelConstructoror directly usePOMLWebviewPanel.
const PanelClass: any = POMLWebviewPanel;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run build-webviewnpm run build-clinpm run lintnpm testpython -m pytest python/testsxvfb-run -a npm run build-extensionxvfb-run -a npm run test-vscodehttps://chatgpt.com/codex/tasks/task_e_68876f6e092c832eb375bd340b22d292