Fix trailing spaces in generated captions#41
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR trims whitespace-only children when building captioned paragraphs, adjusts trailing space logic for captions, and disables trailing spaces for empty answers in the QA components.
- Import and apply
trimChildrenWhiteSpaceinCaptionedParagraphto remove extra whitespace - Pass a boolean
captionTailingSpaceprop to control trailing space rendering - Force
captionTailingSpace={false}for empty answers in theQuestioncomponent
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/poml/components/utils.tsx | Trim children and conditionally set captionTailingSpace in captions |
| packages/poml/components/instructions.tsx | Disable trailing space for empty answer captions |
Comments suppressed due to low confidence (3)
packages/poml/components/utils.tsx:200
- [nitpick] The prop name
captionTailingSpaceappears to have a typo; consider renaming it tocaptionTrailingSpaceto match the standard term and improve clarity.
<Caption captionStyle={captionStyle} captionTailingSpace={hasContent} {...others} />
packages/poml/components/instructions.tsx:543
- [nitpick] The prop name
captionTailingSpaceappears to have a typo; consider renaming it tocaptionTrailingSpacehere as well for consistency.
captionTailingSpace={false}
packages/poml/components/utils.tsx:195
- Consider adding unit tests for
trimChildrenWhiteSpaceto verify that whitespace-only children are removed correctly and thatcaptionTailingSpacetoggles as expected.
const trimmedChildren = trimChildrenWhiteSpace(children, props);
ultmaster
deleted the
ve8idn-codex/fix-extra-space-after---hint----and---answer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run build-webviewnpm run build-clinpm run lintnpm testpython -m pytest python/testshttps://chatgpt.com/codex/tasks/task_e_6863a3b2cf60832e9b63e9859beaaa67