Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the jump-to-source mapping by exposing richContentFromSourceMap and updating all related code paths and tests to support additional mapping indices.
- Exposes and utilizes richContentFromSourceMap for preview output.
- Adjusts mapping node and source segment structures to include original and IR indices.
- Updates tests and panel functionality to work with the new mapping behavior.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/poml/writer.ts | Updates mapping node creation, source segment handling, and removes internal richContentFromSourceMap in favor of the exported version; adds IR index fields. |
| packages/poml/tests/writer.test.tsx | Adjusts tests to reflect new source mapping fields and updated array structure. |
| packages/poml/tests/index.test.tsx | Updates tests to validate the new writeWithSourceMap behavior. |
| packages/poml/index.ts | Exports updated richContentFromSourceMap along with other core constructs. |
| packages/poml/base.tsx | Adds the new richContentFromSourceMap implementation. |
| packages/poml-vscode/* | Updates imports and usage of richContentFromSourceMap and source map fields in panel and LSP code. |
packages/poml/writer.ts
Outdated
| // mappings. If we cannot find a mapping, use the first one as a fallback. | ||
| chosen = result.mappings[0]; | ||
| } | ||
| console.log(start, end, chosen, chosenOriginal); |
There was a problem hiding this comment.
Remove the debug logging statement before merging to production to avoid unintended console output.
| console.log(start, end, chosen, chosenOriginal); | |
| // Debug logging removed for production. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Summary
richContentFromSourceMapand use it for preview outputdata-source-mapTesting
npm testnpm run test-vscodehttps://chatgpt.com/codex/tasks/task_e_685d1e2d1c00832e8a633d95a4a241f8